Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Dario Faggioli <dfaggioli@suse.com>, <xen-devel@lists.xenproject.org>
Cc: "Wei Liu" <wl@xen.org>, "Jan Beulich" <jbeulich@suse.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] xen: x86: make init_intel_cacheinfo() void.
Date: Thu, 26 Mar 2020 17:19:46 +0000
Message-ID: <f4ab2fd8-8644-cb2b-1f9e-450804eafdc6@citrix.com> (raw)
In-Reply-To: <158524305235.31663.14043511848631384508.stgit@Palanthas>

On 26/03/2020 17:17, Dario Faggioli wrote:
> It seems that we took this code from Linux, back when the function was
> 'unsigned int' and the return value was used.
>
> But we are currently not doing anything with such value, so let's get
> rid of it and make the function void. As an anecdote, that's pretty much
> the same that happened in Linux as, since commit 807e9bc8e2fe6 ("x86/CPU:
> Move cpu_detect_cache_sizes() into init_intel_cacheinfo()") the function
> is void there too.
>
> Signed-off-by: Dario Faggioli <dfaggioli@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

Furthermore, Shanghai already uses this in its form.


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26 17:17 Dario Faggioli
2020-03-26 17:19 ` Andrew Cooper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4ab2fd8-8644-cb2b-1f9e-450804eafdc6@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=dfaggioli@suse.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git