From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75286C433E0 for ; Tue, 28 Jul 2020 19:25:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DD5320656 for ; Tue, 28 Jul 2020 19:25:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DD5320656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k0VDg-0006ho-Kj; Tue, 28 Jul 2020 19:25:00 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k0VDf-0006hj-Ds for xen-devel@lists.xenproject.org; Tue, 28 Jul 2020 19:24:59 +0000 X-Inumbo-ID: 06277650-d108-11ea-8bc6-bc764e2007e4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 06277650-d108-11ea-8bc6-bc764e2007e4; Tue, 28 Jul 2020 19:24:58 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EF286AD5B; Tue, 28 Jul 2020 19:25:08 +0000 (UTC) Subject: Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC To: Andrew Cooper References: <58b9211a-f6dd-85da-d0bd-c927ac537a5d@suse.com> <20200727145526.GR7191@Air-de-Roger> <868f864b-ae8e-0b01-8cf0-74a0fd3982ee@citrix.com> From: Jan Beulich Message-ID: Date: Tue, 28 Jul 2020 21:24:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <868f864b-ae8e-0b01-8cf0-74a0fd3982ee@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: "xen-devel@lists.xenproject.org" , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 28.07.2020 15:59, Andrew Cooper wrote: > On 27/07/2020 20:47, Jan Beulich wrote: >> On 27.07.2020 16:55, Roger Pau Monné wrote: >>> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote: >>>> --- /dev/null >>>> +++ b/xen/include/asm-x86/asm-defns.h >>> >>> Maybe this could be asm-insn.h or a different name? I find it >>> confusing to have asm-defns.h and an asm_defs.h. >> >> While indeed I anticipated a reply to this effect, I don't consider >> asm-insn.h or asm-macros.h suitable: We don't want to limit this >> header to a more narrow purpose than "all sorts of definition", I >> don't think. Hence I chose that name despite its similarity to the >> C header's one. > > Roger is correct.  Having asm-defns.h and asm_defs.h is too confusing, > and there is already too much behind the scenes magic here. > > What is the anticipated end result, file wise, because that might > highlight a better way forward. For one I'm afraid I don't understand "file wise" here. The one meaning I could guess can't be it: The name of the file. And then, "the anticipated end result" is at least ambiguous too: You can surely see what the file contains by the end of this series, so again this can't be meant. I have no immediate plans beyond this series, so I can only state what I did say in reply to Roger's remark already: "all sorts of asm definitions". I'd also like to emphasize that asm-defns.h really is a companion of asm_defns.h, supposed to be include only by the latter (as I think can be seen from the patches). In this role I think its name being as similar to its "parent" as suggested makes sufficient sense. Jan