From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D39BC433E0 for ; Sat, 6 Feb 2021 08:47:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA7D364F06 for ; Sat, 6 Feb 2021 08:47:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA7D364F06 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.82089.151716 (Exim 4.92) (envelope-from ) id 1l8JFS-0001W6-VN; Sat, 06 Feb 2021 08:47:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 82089.151716; Sat, 06 Feb 2021 08:47:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l8JFS-0001Vz-Ru; Sat, 06 Feb 2021 08:47:22 +0000 Received: by outflank-mailman (input) for mailman id 82089; Sat, 06 Feb 2021 08:47:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l8JFR-0001Vu-Cm for xen-devel@lists.xenproject.org; Sat, 06 Feb 2021 08:47:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l8JFR-0004fo-33; Sat, 06 Feb 2021 08:47:21 +0000 Received: from [54.239.6.185] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l8JFQ-0000Lx-Qn; Sat, 06 Feb 2021 08:47:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=aCHl8+f/ltmkEPWqrrxaCuzIovfzdfgo+iOfS+H6FX8=; b=XAly+ESxphs9pxEN4sBDCEYAPX nPqlY+uopvgyMMdkpri+QX5Zv2b4zVUsii8pG+1qGIW+vhrdNxD6gkcqRVKnSjT2bUzhE2RHln69p G0UDn8/kiAg6JJmqzJyFDsolcXmSRSBxNShy5fKurF3ndB/pFtIIWbtXD+YBzZ7qPwGU=; Subject: Re: [PATCH] xen/arm: domain_build: Ignore device nodes with invalid addresses To: Stefano Stabellini Cc: Julien Grall , Elliott Mitchell , xen-devel , Volodymyr Babchuk References: <06d6b9ec-0db9-d6da-e30b-df9f9381157d@xen.org> <9b97789b-5560-0186-642a-0501789830e5@xen.org> From: Julien Grall Message-ID: Date: Sat, 6 Feb 2021 08:47:18 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Stefano, On 04/02/2021 22:39, Stefano Stabellini wrote: > After the discussion with Rob, it is clear that we have to add a check > on the node name for "pcie" in dt_bus_pci_match. However, that wouldn't > solve the problem reported by Elliot, because in this case the node name > is "pci" not "pcie". I'd like to point out that in the Linux case, the problem was in the hostbridge and not the PCI device. > > I suggest that we add a check for "pci" too in dt_bus_pci_match, > although that means that our check will be slightly different from the > equivalent Linux check. The "pci" check should come with an in-code > comment to explain the situation and the reasons for it to be. I'd like to follow the same approach as a Linux commit: commit d1ac0002dd297069bb8448c2764c9c31c4668441 Author: Marc Zyngier Date: Wed Aug 19 10:42:55 2020 +0100 of: address: Work around missing device_type property in pcie nodes This means a warning should also be added. Cheers, -- Julien Grall