From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Kevin Tian" <kevin.tian@intel.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <George.Dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [Xen-devel] [PATCH v2] x86/EPT: drop redundant ept_p2m_type_to_flags() parameters
Date: Wed, 22 Jan 2020 15:40:51 +0100 [thread overview]
Message-ID: <f8a610c6-b128-7d3b-09db-e3b7cfe710ad@suse.com> (raw)
All callers set the respective fields in the entry being updated before
the call.
Take the opportunity and also constify the first parameter as well as
make a few style adjustments.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v2: Drop redundant function parameters instead.
--- a/xen/arch/x86/mm/p2m-ept.c
+++ b/xen/arch/x86/mm/p2m-ept.c
@@ -61,8 +61,8 @@ static int atomic_write_ept_entry(struct
return 0;
}
-static void ept_p2m_type_to_flags(struct p2m_domain *p2m, ept_entry_t *entry,
- p2m_type_t type, p2m_access_t access)
+static void ept_p2m_type_to_flags(const struct p2m_domain *p2m,
+ ept_entry_t *entry)
{
/*
* First apply type permissions.
@@ -75,7 +75,7 @@ static void ept_p2m_type_to_flags(struct
* D bit is set for all writable types in EPT leaf entry, except for
* log-dirty type with PML.
*/
- switch(type)
+ switch ( entry->sa_p2mt )
{
case p2m_invalid:
case p2m_mmio_dm:
@@ -143,9 +143,8 @@ static void ept_p2m_type_to_flags(struct
break;
}
-
/* Then restrict with access permissions */
- switch (access)
+ switch ( entry->access )
{
case p2m_access_n:
case p2m_access_n2rwx:
@@ -269,7 +268,7 @@ static bool_t ept_split_super_page(struc
epte->snp = is_iommu_enabled(p2m->domain) && iommu_snoop;
epte->suppress_ve = 1;
- ept_p2m_type_to_flags(p2m, epte, epte->sa_p2mt, epte->access);
+ ept_p2m_type_to_flags(p2m, epte);
if ( (level - 1) == target )
continue;
@@ -521,7 +520,7 @@ static int resolve_misconfig(struct p2m_
if ( nt != e.sa_p2mt )
{
e.sa_p2mt = nt;
- ept_p2m_type_to_flags(p2m, &e, e.sa_p2mt, e.access);
+ ept_p2m_type_to_flags(p2m, &e);
}
e.recalc = 0;
wrc = atomic_write_ept_entry(p2m, &epte[i], e, level);
@@ -574,7 +573,7 @@ static int resolve_misconfig(struct p2m_
e.ipat = ipat;
e.recalc = 0;
if ( recalc && p2m_is_changeable(e.sa_p2mt) )
- ept_p2m_type_to_flags(p2m, &e, e.sa_p2mt, e.access);
+ ept_p2m_type_to_flags(p2m, &e);
wrc = atomic_write_ept_entry(p2m, &epte[i], e, level);
ASSERT(wrc == 0);
}
@@ -789,7 +788,7 @@ ept_set_entry(struct p2m_domain *p2m, gf
iommu_flags )
need_modify_vtd_table = 0;
- ept_p2m_type_to_flags(p2m, &new_entry, p2mt, p2ma);
+ ept_p2m_type_to_flags(p2m, &new_entry);
}
if ( sve != -1 )
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next reply other threads:[~2020-01-22 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 14:40 Jan Beulich [this message]
2020-02-03 5:36 ` [Xen-devel] [PATCH v2] x86/EPT: drop redundant ept_p2m_type_to_flags() parameters Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8a610c6-b128-7d3b-09db-e3b7cfe710ad@suse.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).