From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xenproject.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Stefano Stabellini" <sstabellini@kernel.org>,
stable@vger.kernel.org,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
Subject: Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done
Date: Thu, 4 Nov 2021 11:55:34 -0400 [thread overview]
Message-ID: <f8e52acc-2566-1ed0-d2a3-21e2d468fab7@oracle.com> (raw)
In-Reply-To: <f986a7c4-3032-fecd-2e19-4d63a2ee10c7@oracle.com>
On 11/3/21 9:55 PM, Boris Ostrovsky wrote:
>
> On 11/2/21 5:19 AM, Juergen Gross wrote:
>> When running as PVH or HVM guest with actual memory < max memory the
>> hypervisor is using "populate on demand" in order to allow the guest
>> to balloon down from its maximum memory size. For this to work
>> correctly the guest must not touch more memory pages than its target
>> memory size as otherwise the PoD cache will be exhausted and the guest
>> is crashed as a result of that.
>>
>> In extreme cases ballooning down might not be finished today before
>> the init process is started, which can consume lots of memory.
>>
>> In order to avoid random boot crashes in such cases, add a late init
>> call to wait for ballooning down having finished for PVH/HVM guests.
>>
>> Warn on console if initial ballooning fails, panic() after stalling
>> for more than 3 minutes per default. Add a module parameter for
>> changing this timeout.
>>
>> Cc: <stable@vger.kernel.org>
>> Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
This appears to have noticeable effect on boot time (and boot experience in general).
I have
memory=1024
maxmem=8192
And my boot time (on an admittedly slow box) went from 33 to 45 seconds. And boot pauses in the middle while it is waiting for ballooning to complete.
[ 5.062714] xen:balloon: Waiting for initial ballooning down having finished.
[ 5.449696] random: crng init done
[ 34.613050] xen:balloon: Initial ballooning down finished.
So at least I think we should consider bumping log level down from info.
-boris
next prev parent reply other threads:[~2021-11-04 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 9:19 [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done Juergen Gross
2021-11-04 1:55 ` Boris Ostrovsky
2021-11-04 15:55 ` Boris Ostrovsky [this message]
2021-11-04 16:21 ` Juergen Gross
2021-11-04 16:34 ` Boris Ostrovsky
2021-11-04 16:44 ` Juergen Gross
2021-11-04 17:05 ` Boris Ostrovsky
2021-11-04 16:23 ` Marek Marczykowski-Górecki
2021-11-05 12:18 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8e52acc-2566-1ed0-d2a3-21e2d468fab7@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=corbet@lwn.net \
--cc=jgross@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).