From: George Dunlap <george.dunlap@citrix.com>
To: Tamas K Lengyel <tamas.lengyel@intel.com>,
<xen-devel@lists.xenproject.org>
Cc: "Tamas K Lengyel" <tamas@tklengyel.com>, "Wei Liu" <wl@xen.org>,
"George Dunlap" <george.dunlap@eu.citrix.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool
Date: Thu, 23 Jan 2020 16:14:27 +0000 [thread overview]
Message-ID: <f95e2a51-b866-dc6e-aa10-d81a3f5fd2c3@citrix.com> (raw)
In-Reply-To: <59bdc31b9fcffc92c5a8817aeba8eaa2de75a43c.1579628566.git.tamas.lengyel@intel.com>
On 1/21/20 5:49 PM, Tamas K Lengyel wrote:
> MEM_SHARING_DESTROY_GFN is used on the 'flags' bitfield during unsharing.
> However, the bitfield is not used for anything else, so just convert it to a
> bool instead.
>
> Signed-off-by: Tamas K Lengyel <tamas.lengyel@intel.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
But is there a particular advantage to getting rid of the bitfield?
You're the maintainer, so it's your decision of course. But if it were
me I'd leave it as a bitfield so that all the bitfield code is there if
it's needed in the future. Flipping it to a bool, with the risk of
flipping it back to a bitfield later, seems like pointless churn to me.
(Although perhaps the reason will become evident by the time I get to
the end of the series.)
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2020-01-23 16:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 17:49 [Xen-devel] [PATCH v5 00/18] VM forking Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 01/18] x86/hvm: introduce hvm_copy_context_and_params Tamas K Lengyel
2020-01-22 15:00 ` Jan Beulich
2020-01-22 16:42 ` Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 02/18] xen/x86: Make hap_get_allocation accessible Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 03/18] x86/p2m: Allow p2m_get_page_from_gfn to return shared entries Tamas K Lengyel
2020-01-22 15:23 ` Jan Beulich
2020-01-22 16:51 ` Tamas K Lengyel
2020-01-22 16:55 ` Jan Beulich
2020-01-23 15:32 ` George Dunlap
2020-01-23 15:48 ` Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 04/18] x86/mem_sharing: make get_two_gfns take locks conditionally Tamas K Lengyel
2020-01-23 15:50 ` George Dunlap
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 05/18] x86/mem_sharing: drop flags from mem_sharing_unshare_page Tamas K Lengyel
2020-01-23 15:53 ` George Dunlap
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 06/18] x86/mem_sharing: don't try to unshare twice during page fault Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 07/18] x86/mem_sharing: define mem_sharing_domain to hold some scattered variables Tamas K Lengyel
2020-01-23 15:59 ` George Dunlap
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 08/18] x86/mem_sharing: Use INVALID_MFN and p2m_is_shared in relinquish_shared_pages Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 09/18] x86/mem_sharing: Make add_to_physmap static and shorten name Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 10/18] x86/mem_sharing: Convert MEM_SHARING_DESTROY_GFN to a bool Tamas K Lengyel
2020-01-23 16:14 ` George Dunlap [this message]
2020-01-23 16:23 ` Tamas K Lengyel
2020-01-23 16:32 ` George Dunlap
2020-01-23 16:37 ` Jan Beulich
2020-01-23 16:42 ` George Dunlap
2020-01-23 16:55 ` Jan Beulich
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 11/18] x86/mem_sharing: Replace MEM_SHARING_DEBUG with gdprintk Tamas K Lengyel
2020-01-22 15:30 ` Jan Beulich
2020-01-22 16:55 ` Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 12/18] x86/mem_sharing: Enable mem_sharing on first memop Tamas K Lengyel
2020-01-22 15:32 ` Jan Beulich
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 13/18] x86/mem_sharing: Skip xen heap pages in memshr nominate Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 14/18] x86/mem_sharing: use default_access in add_to_physmap Tamas K Lengyel
2020-01-22 15:35 ` Jan Beulich
2020-01-22 17:08 ` Tamas K Lengyel
2020-01-23 16:44 ` George Dunlap
2020-01-23 17:19 ` Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 15/18] xen/mem_sharing: VM forking Tamas K Lengyel
2020-01-23 17:21 ` George Dunlap
2020-01-23 17:30 ` Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 16/18] xen/mem_access: Use __get_gfn_type_access in set_mem_access Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 17/18] x86/mem_sharing: reset a fork Tamas K Lengyel
2020-01-21 17:49 ` [Xen-devel] [PATCH v5 18/18] xen/tools: VM forking toolstack side Tamas K Lengyel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f95e2a51-b866-dc6e-aa10-d81a3f5fd2c3@citrix.com \
--to=george.dunlap@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=tamas.lengyel@intel.com \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).