From: Oleksii <oleksii.kurochko@gmail.com>
To: Julien Grall <julien@xen.org>, xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Bobby Eshleman <bobby.eshleman@gmail.com>
Subject: Re: [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff
Date: Tue, 07 Feb 2023 13:28:56 +0200 [thread overview]
Message-ID: <f970899e950cab791010a8bbe19fc5001482284b.camel@gmail.com> (raw)
In-Reply-To: <5c6e413b606ae268f0a6a24d347d6dd994598d37.camel@gmail.com>
On Tue, 2023-01-31 at 14:37 +0200, Oleksii wrote:
> Hi Julien,
>
> On Tue, 2023-01-31 at 11:42 +0000, Julien Grall wrote:
> > Hi Oleksii,
> >
> > On 31/01/2023 11:17, Oleksii Kurochko wrote:
> > > Because printk() relies on a serial driver (like the ns16550
> > > driver)
> > > and drivers require working virtual memory (ioremap()) there is
> > > not
> > > print functionality early in Xen boot.
> > >
> > > The patch introduces the basic stuff of early_printk
> > > functionality
> > > which will be enough to print 'hello from C environment".
> > >
> > > Originally early_printk.{c,h} was introduced by Bobby Eshleman
> > > (
> > > https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d
> > > 1aab71384)
> > > but some functionality was changed:
> > > early_printk() function was changed in comparison with the
> > > original
> > > as
> > > common isn't being built now so there is no vscnprintf.
> > >
> > > This commit adds early printk implementation built on the putc
> > > SBI
> > > call.
> > >
> > > As sbi_console_putchar() is already being planned for deprecation
> > > it is used temporarily now and will be removed or reworked after
> > > real uart will be ready.
> > >
> > > Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > > Reviewed-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> > > ---
> > > Changes in V8:
> > > - Nothing was changed
> > > ---
> > > Changes in V7:
> > > - Nothing was changed
> > > ---
> > > Changes in V6:
> > > - Remove __riscv_cmodel_medany check from early_printk.c
> >
> > This discussion is still not resolved. I will echo Jan's point [1]
> > and
> > expand it. There is limited point to keep sending a new version for
> > small changes if there main open points are not addressed.
> >
> > Can you please look at settling done on the issues first and then
> > send a
> > new version?
> Sure, I won't provide new patch series until the issue will be
> resolved.
>
Since Alistair and Bobby agreed that the check is needed I'll send a
new version of the patch series.
> This patch series has been sent to resolve an issue with CI&CD which
> I
> missed after the renaming of task for RISC-V in build.yaml.
>
> ~ Oleksii
> >
> > Cheers,
> >
> > [1] 1d63dd9a-77df-4fca-e35b-886ba19fb35d@suse.com
> >
>
~ Oleksii
next prev parent reply other threads:[~2023-02-07 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 11:17 [PATCH v8 0/2] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-31 11:17 ` [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-31 11:42 ` Julien Grall
2023-01-31 12:37 ` Oleksii
2023-02-07 11:28 ` Oleksii [this message]
2023-01-31 11:17 ` [PATCH v8 2/2] automation: update RISC-V smoke test Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f970899e950cab791010a8bbe19fc5001482284b.camel@gmail.com \
--to=oleksii.kurochko@gmail.com \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobby.eshleman@gmail.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).