xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Paul Durrant <Paul.Durrant@citrix.com>
To: 'Jan Beulich' <JBeulich@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Andrew Cooper <Andrew.Cooper3@citrix.com>,
	'Suravee Suthikulpanit' <suravee.suthikulpanit@amd.com>,
	'xen-devel' <xen-devel@lists.xenproject.org>,
	'Brian Woods' <brian.woods@amd.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH v3 1/4] amd-iommu: add flush iommu_ops
Date: Wed, 5 Dec 2018 12:58:35 +0000	[thread overview]
Message-ID: <f9c9a57e24794d2da1fd4ca58087279f@AMSPEX02CL03.citrite.net> (raw)
In-Reply-To: <06f4edfeb8824993bc0cc59e56eebc12@AMSPEX02CL03.citrite.net>

> -----Original Message-----
> From: Paul Durrant
> Sent: 05 December 2018 12:57
> To: 'Jan Beulich' <JBeulich@suse.com>
> Cc: Brian Woods <brian.woods@amd.com>; Suravee Suthikulpanit
> <suravee.suthikulpanit@amd.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; Roger Pau Monne <roger.pau@citrix.com>; Wei
> Liu <wei.liu2@citrix.com>; xen-devel <xen-devel@lists.xenproject.org>
> Subject: RE: [PATCH v3 1/4] amd-iommu: add flush iommu_ops
> 
> > -----Original Message-----
> > From: Jan Beulich [mailto:JBeulich@suse.com]
> > Sent: 05 December 2018 11:46
> > To: Paul Durrant <Paul.Durrant@citrix.com>
> > Cc: Brian Woods <brian.woods@amd.com>; Suravee Suthikulpanit
> > <suravee.suthikulpanit@amd.com>; Andrew Cooper
> > <Andrew.Cooper3@citrix.com>; Roger Pau Monne <roger.pau@citrix.com>; Wei
> > Liu <wei.liu2@citrix.com>; xen-devel <xen-devel@lists.xenproject.org>
> > Subject: Re: [PATCH v3 1/4] amd-iommu: add flush iommu_ops
> >
> > >>> On 05.12.18 at 12:29, <paul.durrant@citrix.com> wrote:
> > > --- a/xen/drivers/passthrough/amd/iommu_map.c
> > > +++ b/xen/drivers/passthrough/amd/iommu_map.c
> > > @@ -634,6 +634,56 @@ int amd_iommu_unmap_page(struct domain *d, dfn_t
> > dfn)
> > >      spin_unlock(&hd->arch.mapping_lock);
> > >
> > >      amd_iommu_flush_pages(d, dfn_x(dfn), 0);
> > > +    return 0;
> > > +}
> > > +
> > > +static unsigned long flush_count(unsigned long dfn, unsigned int
> > page_count,
> > > +                                 unsigned int order)
> > > +{
> > > +    unsigned long start = dfn >> order;
> > > +    unsigned long end = (dfn + page_count - 1) >> 1;
> >
> > Granted in my earlier reply I had a missing opening parenthesis,
> > but the above is pretty clearly the wrong way of addressing
> > the resulting build error.
> 
> Sorry, that's way too cryptic. What build error?

I agree there is a typo there, in that the '>> 1' should be '>> order'... Is that what you're getting at?

  Paul

> 
>   Paul
> 
> >
> > Jan
> >


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-12-05 12:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 11:29 [PATCH v3 0/4] iommu improvements Paul Durrant
2018-12-05 11:29 ` [PATCH v3 1/4] amd-iommu: add flush iommu_ops Paul Durrant
2018-12-05 11:46   ` Jan Beulich
2018-12-05 12:56     ` Paul Durrant
2018-12-05 12:58       ` Paul Durrant [this message]
2018-12-05 13:13         ` Jan Beulich
2018-12-05 13:15           ` Paul Durrant
2018-12-05 13:47             ` Jan Beulich
2018-12-05 11:29 ` [PATCH v3 2/4] iommu: rename wrapper functions Paul Durrant
2018-12-06 14:44   ` Jan Beulich
2018-12-06 15:00     ` Andrew Cooper
2018-12-05 11:29 ` [PATCH v3 3/4] iommu: elide flushing for higher order map/unmap operations Paul Durrant
2018-12-06 15:08   ` Jan Beulich
2018-12-06 15:11     ` Paul Durrant
2018-12-05 11:29 ` [PATCH v3 4/4] x86/mm/p2m: stop checking for IOMMU shared page tables in mmio_order() Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9c9a57e24794d2da1fd4ca58087279f@AMSPEX02CL03.citrite.net \
    --to=paul.durrant@citrix.com \
    --cc=Andrew.Cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=brian.woods@amd.com \
    --cc=roger.pau@citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).