From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE70C64E7B for ; Tue, 1 Dec 2020 13:15:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1526B20637 for ; Tue, 1 Dec 2020 13:15:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ODQLz2yc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1526B20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.42018.75562 (Exim 4.92) (envelope-from ) id 1kk5VA-0003dP-8U; Tue, 01 Dec 2020 13:15:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 42018.75562; Tue, 01 Dec 2020 13:15:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kk5VA-0003dI-5I; Tue, 01 Dec 2020 13:15:28 +0000 Received: by outflank-mailman (input) for mailman id 42018; Tue, 01 Dec 2020 13:15:26 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kk5V8-0003d9-IZ for xen-devel@lists.xenproject.org; Tue, 01 Dec 2020 13:15:26 +0000 Received: from mail-lf1-x141.google.com (unknown [2a00:1450:4864:20::141]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5f7492e2-814e-4c98-acf4-a4b3dd7f5980; Tue, 01 Dec 2020 13:15:25 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id s30so4041561lfc.4 for ; Tue, 01 Dec 2020 05:15:25 -0800 (PST) Received: from [192.168.10.4] ([185.199.97.5]) by smtp.gmail.com with ESMTPSA id d20sm198780lfe.174.2020.12.01.05.15.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 05:15:23 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f7492e2-814e-4c98-acf4-a4b3dd7f5980 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=xpUvP3GsuZ5Zr8GiUBIEZ3Q5BpQaKqmylsT1wwgYw8s=; b=ODQLz2yczPSppQnvYLKeg1TWErMot8t/pR0qN81cqdpACQ6yPuAD6PqFFCZXuwDEJS bp3UpnTpw7jLOvdlFllO8n2fQa8s+LIAWCTBiOhWSsYHvJkPfg00KIYahV1INIFIx3Wh reyDCHN40XQt3Dco3Xrx0ViU9jFTnRU5IIwfJi4e6KFN6WQCs6d0nw7ubq5DphZaHdn3 dyY3Z9xd+JFevwhC23rK07/bn2e7+wIBfWu4Y6/VH/5OPbYjaclyrLOSPPbZDOKIAhFX bPqgjg+dxIWEa37JBCmApo21sH8dTAfwlGEyHVNljjozdjnF0q9Dqus/jet0kAZgcmWV uzZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=xpUvP3GsuZ5Zr8GiUBIEZ3Q5BpQaKqmylsT1wwgYw8s=; b=rYI9TB/r8eafxOMOhK6Z1zT46knHU3TMNbZb4SMHq4Xcpgj88VnE46DDqtmhJG6Mwr ALhLIjwR99O3o6857UPxdyt7xMBTRpnv45ryKl4Z6VKuffO9b1s5XWjdk5QaEnS3ToFW JYvoLIEevX1GpLy1a8PbcSDAerZ7B/f04NmrTeliRwmvBf9yvEgBPgXCMuvQgfwURkHy +bWXW/zxKmXpKaBLcurw7xW+jZdDMCUuJmqblYkxhpkhDz5ynVPIftHC4GahyEVc7yEl nUiI5QNIic6EISmI2HYKlQno2wwxhYL+0zeVGSroWz/7L/sBn5SsSog5wpl1DbN9Tlda zPcA== X-Gm-Message-State: AOAM531S3dZjOp+9/GiheHlAGoEkYi5UakpyIRnASriWC/9JhqOL/kru FRUrzEtOgIlU+AFz6p/E46g= X-Google-Smtp-Source: ABdhPJwtlIwXmM2btWSCgdX9bRh5+0p0ovuSx9BJQdDYJwwRYpejw5hqNjg0ac2/1Xz90PUHhQ88Mw== X-Received: by 2002:a19:5015:: with SMTP id e21mr1088305lfb.566.1606828524468; Tue, 01 Dec 2020 05:15:24 -0800 (PST) Subject: Re: [PATCH v4 05/23] libxl: s/detatched/detached in libxl_pci.c To: Paul Durrant , xen-devel@lists.xenproject.org Cc: Paul Durrant , Ian Jackson , Wei Liu References: <20201124080159.11912-1-paul@xen.org> <20201124080159.11912-6-paul@xen.org> From: Oleksandr Andrushchenko Message-ID: Date: Tue, 1 Dec 2020 15:15:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201124080159.11912-6-paul@xen.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Hi, Paul! On 11/24/20 10:01 AM, Paul Durrant wrote: > From: Paul Durrant > > Simply spelling correction. Purely cosmetic fix. > > Signed-off-by: Paul Durrant Reviewed-by: Oleksandr Andrushchenko Thank you, Oleksandr > --- > Cc: Ian Jackson > Cc: Wei Liu > --- > tools/libs/light/libxl_pci.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c > index 50c96cbfa6..de617e95eb 100644 > --- a/tools/libs/light/libxl_pci.c > +++ b/tools/libs/light/libxl_pci.c > @@ -1864,7 +1864,7 @@ static void pci_remove_qmp_query_cb(libxl__egc *egc, > libxl__ev_qmp *qmp, const libxl__json_object *response, int rc); > static void pci_remove_timeout(libxl__egc *egc, > libxl__ev_time *ev, const struct timeval *requested_abs, int rc); > -static void pci_remove_detatched(libxl__egc *egc, > +static void pci_remove_detached(libxl__egc *egc, > pci_remove_state *prs, int rc); > static void pci_remove_stubdom_done(libxl__egc *egc, > libxl__ao_device *aodev); > @@ -1978,7 +1978,7 @@ skip1: > skip_irq: > rc = 0; > out_fail: > - pci_remove_detatched(egc, prs, rc); /* must be last */ > + pci_remove_detached(egc, prs, rc); /* must be last */ > } > > static void pci_remove_qemu_trad_watch_state_cb(libxl__egc *egc, > @@ -2002,7 +2002,7 @@ static void pci_remove_qemu_trad_watch_state_cb(libxl__egc *egc, > rc = qemu_pci_remove_xenstore(gc, domid, pci, prs->force); > > out: > - pci_remove_detatched(egc, prs, rc); > + pci_remove_detached(egc, prs, rc); > } > > static void pci_remove_qmp_device_del(libxl__egc *egc, > @@ -2028,7 +2028,7 @@ static void pci_remove_qmp_device_del(libxl__egc *egc, > return; > > out: > - pci_remove_detatched(egc, prs, rc); > + pci_remove_detached(egc, prs, rc); > } > > static void pci_remove_qmp_device_del_cb(libxl__egc *egc, > @@ -2051,7 +2051,7 @@ static void pci_remove_qmp_device_del_cb(libxl__egc *egc, > return; > > out: > - pci_remove_detatched(egc, prs, rc); > + pci_remove_detached(egc, prs, rc); > } > > static void pci_remove_qmp_retry_timer_cb(libxl__egc *egc, libxl__ev_time *ev, > @@ -2067,7 +2067,7 @@ static void pci_remove_qmp_retry_timer_cb(libxl__egc *egc, libxl__ev_time *ev, > return; > > out: > - pci_remove_detatched(egc, prs, rc); > + pci_remove_detached(egc, prs, rc); > } > > static void pci_remove_qmp_query_cb(libxl__egc *egc, > @@ -2127,7 +2127,7 @@ static void pci_remove_qmp_query_cb(libxl__egc *egc, > } > > out: > - pci_remove_detatched(egc, prs, rc); /* must be last */ > + pci_remove_detached(egc, prs, rc); /* must be last */ > } > > static void pci_remove_timeout(libxl__egc *egc, libxl__ev_time *ev, > @@ -2146,12 +2146,12 @@ static void pci_remove_timeout(libxl__egc *egc, libxl__ev_time *ev, > /* If we timed out, we might still want to keep destroying the device > * (when force==true), so let the next function decide what to do on > * error */ > - pci_remove_detatched(egc, prs, rc); > + pci_remove_detached(egc, prs, rc); > } > > -static void pci_remove_detatched(libxl__egc *egc, > - pci_remove_state *prs, > - int rc) > +static void pci_remove_detached(libxl__egc *egc, > + pci_remove_state *prs, > + int rc) > { > STATE_AO_GC(prs->aodev->ao); > int stubdomid = 0;