From: Jan Beulich <jbeulich@suse.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH RFC] EFI: strip xen.efi when putting it on the EFI partition
Date: Mon, 2 May 2022 16:47:30 +0200 [thread overview]
Message-ID: <fa1acccc-0a02-bfec-2778-f6db8bf1a8fa@suse.com> (raw)
In-Reply-To: <394c1b94-beaf-bdcb-c333-65dd9987be54@suse.com>
On 25.04.2022 12:46, Jan Beulich wrote:
> With debug info retained, xen.efi can be quite large. Unlike for xen.gz
> there's no intermediate step (mkelf32 there) involved which would strip
> debug info kind of as a side effect. While the installing of xen.efi on
> the EFI partition is an optional step (intended to be a courtesy to the
> developer), adjust it also for the purpose of documenting what distros
> would be expected to do during boot loader configuration (which is what
> would normally put xen.efi into the EFI partition).
>
> Model the control over stripping after Linux'es module installation,
> except that the stripped executable is constructed in the build area
> instead of in the destination location. This is to conserve on space
> used there - EFI partitions tend to be only a few hundred Mb in size.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> RFC: GNU strip 2.38 appears to have issues when acting on a PE binary:
> - the new file positions of the sections do not respect the file
> alignment specified by the header (a resulting looks to work on
> one EFI implementation where I did actually try it, but I don't
> think we can rely on that),
> - file name symbols are also stripped; while there is a separate
> --keep-file-symbols option (which I would have thought to be on
> by default anyway), its use makes no difference.
Update to these items: The first one turned out to be an issue with a
not-yet-upstream patch that I've been carrying for a long time. I've
fixed that up, and will submit that patch (perhaps together with
further ones) in due course. Apart from that the list of remarks now
is
- file name symbols are also stripped; while there is a separate
--keep-file-symbols option (which I would have thought to be on by
default anyway), its use so far makes no difference,
- the string table grows in size, when one would expect it to shrink,
- linker version is changed in and timestamp zapped from the header.
Locally I have draft patches for all of these issues, but this means
stripping won't work overly well until at least 2.39.
Jan
prev parent reply other threads:[~2022-05-02 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 10:46 [PATCH RFC] EFI: strip xen.efi when putting it on the EFI partition Jan Beulich
2022-04-26 12:26 ` Bertrand Marquis
2022-04-26 14:09 ` Jan Beulich
2022-04-26 14:52 ` Bertrand Marquis
2022-05-02 14:47 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa1acccc-0a02-bfec-2778-f6db8bf1a8fa@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).