From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A07CC433ED for ; Wed, 21 Apr 2021 15:34:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 018BE6143D for ; Wed, 21 Apr 2021 15:34:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 018BE6143D Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.114862.218979 (Exim 4.92) (envelope-from ) id 1lZEs3-0004qa-Pc; Wed, 21 Apr 2021 15:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 114862.218979; Wed, 21 Apr 2021 15:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEs3-0004qT-Me; Wed, 21 Apr 2021 15:34:31 +0000 Received: by outflank-mailman (input) for mailman id 114862; Wed, 21 Apr 2021 15:34:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lZEs3-0004qO-6B for xen-devel@lists.xenproject.org; Wed, 21 Apr 2021 15:34:31 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id e7b9b76f-5799-4841-b26b-1d28f7fd7936; Wed, 21 Apr 2021 15:34:30 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9AFABB4F4; Wed, 21 Apr 2021 15:34:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7b9b76f-5799-4841-b26b-1d28f7fd7936 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619019269; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hx6gVI3xRsjkXarMiANOTT/HKfqcKKR2dg+OLV983X8=; b=e2Cxvdb/e8C0pIv1dbxHXPts2XAsPkEZAZ7f5qpFOYnkrM76G8gATimRxB+jyN5q0zYE17 5Dw6W7xHijgjLdQh4GXh4NxCTjWYIWa+0UpwGXt9ij1FnqBWtRNqdlkioJXvt3wEJY28pD VMb7MKUAQ0khkF9k+h5V1s0sa8opzWw= Subject: Re: [PATCH 6/8] x86/EFI: avoid use of GNU ld's --disable-reloc-section when possible To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu References: From: Jan Beulich Message-ID: Date: Wed, 21 Apr 2021 17:34:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 21.04.2021 17:20, Roger Pau Monné wrote: > On Wed, Apr 21, 2021 at 02:03:49PM +0200, Jan Beulich wrote: >> On 21.04.2021 12:21, Roger Pau Monné wrote: >>> On Thu, Apr 01, 2021 at 11:46:44AM +0200, Jan Beulich wrote: >>>> @@ -189,7 +208,11 @@ EFI_LDFLAGS += --no-insert-timestamp >>>> endif >>>> >>>> $(TARGET).efi: VIRT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A VIRT_START$$,,p') >>>> +ifeq ($(MKRELOC),:) >>>> +$(TARGET).efi: ALT_BASE := >>>> +else >>>> $(TARGET).efi: ALT_BASE = 0x$(shell $(NM) efi/relocs-dummy.o | sed -n 's, A ALT_START$$,,p') >>> >>> Could you maybe check whether $(relocs-dummy) is set as the condition >>> here and use it here instead of efi/relocs-dummy.o? >> >> I can use it in the ifeq() if you think that's neater (the current way >> is minimally shorter), but using it in the ALT_BASE assignment would >> make this differ more from the VIRT_BASE one, which I'd like to avoid. > > Sorry, I think I'm slightly confused because when the linker can > produce the required relocations relocs-dummy variable is left empty, > so it won't be added to $(TARGET).efi. > > But we still need to generate the efi/relocs-dummy.o file for the ELF > build I assume? Not anymore (after "x86/EFI: redo .reloc section bounds determination"). We need it, as said, to fish VIRT_BASE out of it. It indeed wouldn't get linked into any of the final binaries anymore. Jan