From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH] x86/msr: Virtualise MSR_PLATFORM_ID properly
Date: Fri, 28 Feb 2020 10:11:03 +0100 [thread overview]
Message-ID: <faec15bd-0138-e6d5-a3a4-7627c4d3aa54@suse.com> (raw)
In-Reply-To: <20200214195510.22667-1-andrew.cooper3@citrix.com>
On 14.02.2020 20:55, Andrew Cooper wrote:
> --- a/xen/arch/x86/msr.c
> +++ b/xen/arch/x86/msr.c
> @@ -143,6 +143,13 @@ int guest_rdmsr(struct vcpu *v, uint32_t msr, uint64_t *val)
> /* Not offered to guests. */
> goto gp_fault;
>
> + case MSR_IA32_PLATFORM_ID:
> + if ( !(cp->x86_vendor & X86_VENDOR_INTEL) ||
> + !(boot_cpu_data.x86_vendor & X86_VENDOR_INTEL) )
This has turned out to be an unfortunate trap for backporting.
While I understand using & here is the more modern form, could
we perhaps settle on using == / != where possible (i.e. just a
single vendor checked) until 4.12 has gone out of at least
regular support? (The prevailing use with more than one vendor
is with AMD and Hygon, which doesn't go silent as
X86_VENDOR_HYGON doesn't exist yet in 4.12.)
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2020-02-28 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 19:55 [Xen-devel] [PATCH] x86/msr: Virtualise MSR_PLATFORM_ID properly Andrew Cooper
2020-02-18 13:28 ` Jan Beulich
2020-02-28 9:11 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faec15bd-0138-e6d5-a3a4-7627c4d3aa54@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).