From: Julien Grall <julien@xen.org>
To: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
xen-devel@lists.xenproject.org
Cc: Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Gianluca Guida <gianluca@rivosinc.com>,
Bob Eshleman <bobbyeshleman@gmail.com>,
Alistair Francis <alistair.francis@wdc.com>,
Connor Davis <connojdavis@gmail.com>,
Bobby Eshleman <bobby.eshleman@gmail.com>
Subject: Re: [PATCH v6 1/2] xen/riscv: introduce early_printk basic stuff
Date: Fri, 27 Jan 2023 11:26:46 +0000 [thread overview]
Message-ID: <fbab23b9-663e-9516-5721-a92486686f84@xen.org> (raw)
In-Reply-To: <06c2c36bd68b2534c757dc4087476e855253680a.1674816429.git.oleksii.kurochko@gmail.com>
Hi,
On 27/01/2023 11:15, Oleksii Kurochko wrote:
> Because printk() relies on a serial driver (like the ns16550 driver)
> and drivers require working virtual memory (ioremap()) there is not
> print functionality early in Xen boot.
>
> The patch introduces the basic stuff of early_printk functionality
> which will be enough to print 'hello from C environment".
>
> Originally early_printk.{c,h} was introduced by Bobby Eshleman
> (https://github.com/glg-rv/xen/commit/a3c9916bbdff7ad6030055bbee7e53d1aab71384)
> but some functionality was changed:
> early_printk() function was changed in comparison with the original as
> common isn't being built now so there is no vscnprintf.
>
> This commit adds early printk implementation built on the putc SBI call.
>
> As sbi_console_putchar() is already being planned for deprecation
> it is used temporarily now and will be removed or reworked after
> real uart will be ready.
>
> Signed-off-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> Reviewed-by: Bobby Eshleman <bobby.eshleman@gmail.com>
> ---
> Changes in V6:
> - Remove __riscv_cmodel_medany check from early_printk.c
Why? I know Andrew believed this is wrong, but I replied back with my
understanding and saw no discussion afterwards explaining why I am
incorrect.
I am not a maintainer of the code here, but I don't particularly
appreciate comments to be ignored. If there was any discussion on IRC,
then please summarize them here.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-01-27 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 11:15 [PATCH v6 0/2] Basic early_printk and smoke test implementation Oleksii Kurochko
2023-01-27 11:15 ` [PATCH v6 1/2] xen/riscv: introduce early_printk basic stuff Oleksii Kurochko
2023-01-27 11:26 ` Julien Grall [this message]
2023-01-27 11:49 ` Oleksii
2023-01-27 12:22 ` Julien Grall
2023-01-27 11:15 ` [PATCH v6 2/2] automation: add RISC-V smoke test Oleksii Kurochko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbab23b9-663e-9516-5721-a92486686f84@xen.org \
--to=julien@xen.org \
--cc=alistair.francis@wdc.com \
--cc=andrew.cooper3@citrix.com \
--cc=bobby.eshleman@gmail.com \
--cc=bobbyeshleman@gmail.com \
--cc=connojdavis@gmail.com \
--cc=gianluca@rivosinc.com \
--cc=jbeulich@suse.com \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).