From: Juergen Gross <jgross@suse.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: xen-devel@lists.xenproject.org, Ian Jackson <iwj@xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored
Date: Fri, 11 Jun 2021 09:07:24 +0200 [thread overview]
Message-ID: <fcb0a1d6-c392-e0a1-2ec6-d6cf6a40d6bf@suse.com> (raw)
In-Reply-To: <20210611074616.2a4b96fb.olaf@aepfle.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 869 bytes --]
On 11.06.21 07:46, Olaf Hering wrote:
> Am Fri, 11 Jun 2021 07:01:31 +0200
> schrieb Juergen Gross <jgross@suse.com>:
>
>> Why? You realize that above is a comment just documenting the default?
>
> That depends on the context. See https://bugzilla.opensuse.org/show_bug.cgi?id=1185682 for a reason why it should become an empty variable. But yes, we can patch that one too.
Isn't that a bug in fillup or the related rpm-macro? A variable set in
the existing /etc/sysconfig/xencommons file only should be preserved.
In general I think we should be consistent in the file.
In case there is no downside for other distributions I'd recommend to
switch all variables to your suggested pattern.
If there are disadvantages for others we should keep the current
pattern as changing it now would break existing installations.
Any thoughts?
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-06-11 7:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 5:58 [PATCH v2 0/2] tools/xenstore: set resource limits of xenstored Juergen Gross
2021-06-08 5:58 ` [PATCH v2 1/2] tools/xenstore: set oom score for xenstore daemon on Linux Juergen Gross
2021-07-08 17:40 ` Julien Grall
2021-07-09 12:34 ` Juergen Gross
2021-07-12 8:38 ` Julien Grall
2021-06-08 5:58 ` [PATCH v2 2/2] tools/xenstore: set open file descriptor limit for xenstored Juergen Gross
2021-06-08 16:39 ` Olaf Hering
2021-06-11 5:01 ` Juergen Gross
2021-06-11 5:46 ` Olaf Hering
2021-06-11 7:07 ` Juergen Gross [this message]
2021-06-11 7:28 ` Olaf Hering
2021-07-07 7:23 ` [PATCH v2 0/2] tools/xenstore: set resource limits of xenstored Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fcb0a1d6-c392-e0a1-2ec6-d6cf6a40d6bf@suse.com \
--to=jgross@suse.com \
--cc=iwj@xenproject.org \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).