From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CC0C433FE for ; Fri, 4 Dec 2020 16:57:09 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B28022B2A for ; Fri, 4 Dec 2020 16:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B28022B2A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.44962.80420 (Exim 4.92) (envelope-from ) id 1klENs-0000CX-Do; Fri, 04 Dec 2020 16:56:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 44962.80420; Fri, 04 Dec 2020 16:56:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klENs-0000CQ-Ag; Fri, 04 Dec 2020 16:56:40 +0000 Received: by outflank-mailman (input) for mailman id 44962; Fri, 04 Dec 2020 16:56:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1klENr-0000CL-1a for xen-devel@lists.xenproject.org; Fri, 04 Dec 2020 16:56:39 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id cdd6546f-b220-449a-ac11-e220d4a7b2be; Fri, 04 Dec 2020 16:56:38 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4DB09ACBA; Fri, 4 Dec 2020 16:56:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdd6546f-b220-449a-ac11-e220d4a7b2be X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607100997; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cRdRUxehcl4ZfniJoAzlXcTcyM8p7bZ7J7D2+BOTM3A=; b=fjiYY2loQBSO+gUsGktexv/ZTlU/l1Pn3gbmQ1B66ONRV3ZzFRhhxfax/coSgZZM/mB6Gy 2pIq4OFXHPDzwBHZznfsKc399pMaPIQ8EITLQABxZriRp0i9wEvzDIGK8ap778eLfvuGuX /kn5mT0z0zJeiAbQCnxUJWZ2AwbOwM4= Message-ID: Subject: Re: [PATCH v2 05/17] xen/cpupool: switch cpupool list to normal list interface From: Dario Faggioli To: Juergen Gross , xen-devel@lists.xenproject.org Cc: George Dunlap Date: Fri, 04 Dec 2020 17:56:36 +0100 In-Reply-To: <20201201082128.15239-6-jgross@suse.com> References: <20201201082128.15239-1-jgross@suse.com> <20201201082128.15239-6-jgross@suse.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-Y4odgjyWSGvy9y5OHjc7" User-Agent: Evolution 3.38.2 (by Flathub.org) MIME-Version: 1.0 --=-Y4odgjyWSGvy9y5OHjc7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2020-12-01 at 09:21 +0100, Juergen Gross wrote: > Instead of open coding something like a linked list just use the > available functionality from list.h. >=20 Yep, much better. > While adding the required new include to private.h sort the includes. >=20 > Signed-off-by: From: Juergen Gross > Reviewed-by: Dario Faggioli We've discussed about the issue of creating too many cpupools later in the thread already. If, as stated there, a comment or (much better, IMO) a mention about that in the changelog is added, the R-o-b still stands. Regards --=20 Dario Faggioli, Ph.D http://about.me/dario.faggioli Virtualization Software Engineer SUSE Labs, SUSE https://www.suse.com/ ------------------------------------------------------------------- <> (Raistlin Majere) --=-Y4odgjyWSGvy9y5OHjc7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEES5ssOj3Vhr0WPnOLFkJ4iaW4c+4FAl/KakQACgkQFkJ4iaW4 c+5UIxAA6ZloExN3e4Iq9ew0cL/CEPKQ8fom44a30YnsXmStU2ARoLPlt2qJ+QwV 4by4e1YYvwWDBKJXIWA0TlLzAZodXcPPJ/N9GcGUQuvZw8829psyfLfc6e+MAH+T Hj2zKpbJG8/PbReRG3hh8HUq0U+pAZ1xfdIXyR2sLsfSj4sUOv2efTl/6LiVVp42 2joGpLFmqvlbfV0TpvpvEeyLFmkwtQn/LjN/oBUWCUEM7GcI7EOtEgH/cvGlckXr LiuKGb3q0Qd0x44hpWv45kzjz1rB8R636LrqQsz79bs1Bej2grV4oK/QI94FKWoU mlHRwFddQvm2LWkfuMPkEgIAqRjdluBonGPz9dfKj2sI29bb6rgzjEPl6sDSwSRZ Cdvg+JsX4tpxGuwbyAHN2gew1/ruaemj4fG+I2O2K7VM520IjDtQasJvNvDoLgX8 F84wvgpBfF1W0ugsr7kby7Lh///BzSgbpk1KLEGZy140SBwjgrgfwagLW/3fW57N qQKtg2ecCLBr7pMm7FryR4CaMMlDbWxb7CO0MUrw+x1+bGa65mQQPNunNYzYmmke XwwCMbCLtSmoUlrVfR+qfrS4YWIatjFnlb6vbqBQoxxHi65LwJp0gXRpU5T1VoiB YoPb0XHUKqGAg0mgXkNNEsMdiwLaai8a3Z+DJ/hpY86uvQJwVEI= =/d0r -----END PGP SIGNATURE----- --=-Y4odgjyWSGvy9y5OHjc7--