From: Paul Durrant <Paul.Durrant@citrix.com> To: Roger Pau Monne <roger.pau@citrix.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, "Tim \(Xen.org\)" <tim@xen.org>, George Dunlap <George.Dunlap@citrix.com>, Julien Grall <julien.grall@arm.com>, Jan Beulich <jbeulich@suse.com>, Ian Jackson <Ian.Jackson@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org> Subject: Re: [Xen-devel] [PATCH 7/7] ioreq: provide support for long-running operations... Date: Thu, 22 Aug 2019 13:07:47 +0000 Message-ID: <fe1a7334d57343a9973c1baebcc41757@AMSPEX02CL03.citrite.net> (raw) In-Reply-To: <20190822125528.fzdhu6wjtsg7v2no@Air-de-Roger> > -----Original Message----- > From: Roger Pau Monne <roger.pau@citrix.com> > Sent: 22 August 2019 13:55 > To: Paul Durrant <Paul.Durrant@citrix.com> > Cc: xen-devel@lists.xenproject.org; Jan Beulich <jbeulich@suse.com>; Andrew Cooper > <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; George Dunlap <George.Dunlap@citrix.com>; Ian > Jackson <Ian.Jackson@citrix.com>; Julien Grall <julien.grall@arm.com>; Konrad Rzeszutek Wilk > <konrad.wilk@oracle.com>; Stefano Stabellini <sstabellini@kernel.org>; Tim (Xen.org) <tim@xen.org> > Subject: Re: [PATCH 7/7] ioreq: provide support for long-running operations... > > On Thu, Aug 22, 2019 at 11:15:50AM +0200, Paul Durrant wrote: > > > -----Original Message----- > > > From: Roger Pau Monne <roger.pau@citrix.com> > > > Sent: 21 August 2019 15:59 > > > To: xen-devel@lists.xenproject.org > > > Cc: Roger Pau Monne <roger.pau@citrix.com>; Paul Durrant <Paul.Durrant@citrix.com>; Jan Beulich > > > <jbeulich@suse.com>; Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; George > Dunlap > > > <George.Dunlap@citrix.com>; Ian Jackson <Ian.Jackson@citrix.com>; Julien Grall > <julien.grall@arm.com>; > > > Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Stefano Stabellini <sstabellini@kernel.org>; Tim > > > (Xen.org) <tim@xen.org> > > > Subject: [PATCH 7/7] ioreq: provide support for long-running operations... > > > > > > ...and switch vPCI to use this infrastructure for long running > > > physmap modification operations. > > > > > > This allows to get rid of the vPCI specific modifications done to > > > handle_hvm_io_completion and allows generalizing the support for > > > long-running operations to other internal ioreq servers. Such support > > > is implemented as a specific handler that can be registers by internal > > > ioreq servers and that will be called to check for pending work. > > > Returning true from this handler will prevent the vcpu from running > > > until the handler returns false. > > > > Rather than having another callback can the handler not be re-called with same ioreq? It could > return different values depending on whether there is more work to do (requiring another call) or > whether it is done and the vcpu can be resumed. Would that work? > > I guess this would work also. The issue with this approach is that I > would have to find somewhere to store the ioreq while the operation is > being processed, which is not required with the proposed two handler > approach. The ioreq already is stored in v->arch.hvm.hvm_io.io_req anyway, so can't you use that copy? Paul > > Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply index Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-21 14:58 [Xen-devel] [PATCH 0/7] ioreq: add support for internal servers Roger Pau Monne 2019-08-21 14:58 ` [Xen-devel] [PATCH 1/7] ioreq: add fields to allow internal ioreq servers Roger Pau Monne 2019-08-21 14:58 ` [Xen-devel] [PATCH 2/7] ioreq: add internal ioreq initialization support Roger Pau Monne 2019-08-21 16:24 ` Paul Durrant 2019-08-22 7:23 ` Roger Pau Monné 2019-08-22 8:30 ` Paul Durrant 2019-08-21 14:58 ` [Xen-devel] [PATCH 3/7] ioreq: allow dispatching ioreqs to internal servers Roger Pau Monne 2019-08-21 16:29 ` Paul Durrant 2019-08-22 7:40 ` Roger Pau Monné 2019-08-22 8:33 ` Paul Durrant 2019-08-21 14:59 ` [Xen-devel] [PATCH 4/7] ioreq: allow registering internal ioreq server handler Roger Pau Monne 2019-08-21 16:35 ` Paul Durrant 2019-08-22 7:43 ` Roger Pau Monné 2019-08-22 8:38 ` Paul Durrant 2019-08-21 14:59 ` [Xen-devel] [PATCH 5/7] ioreq: allow decoding accesses to MMCFG regions Roger Pau Monne 2019-08-21 14:59 ` [Xen-devel] [PATCH 6/7] vpci: register as an internal ioreq server Roger Pau Monne 2019-08-21 14:59 ` [Xen-devel] [PATCH 7/7] ioreq: provide support for long-running operations Roger Pau Monne 2019-08-22 9:15 ` Paul Durrant 2019-08-22 12:55 ` Roger Pau Monné 2019-08-22 13:07 ` Paul Durrant [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fe1a7334d57343a9973c1baebcc41757@AMSPEX02CL03.citrite.net \ --to=paul.durrant@citrix.com \ --cc=Andrew.Cooper3@citrix.com \ --cc=George.Dunlap@citrix.com \ --cc=Ian.Jackson@citrix.com \ --cc=jbeulich@suse.com \ --cc=julien.grall@arm.com \ --cc=konrad.wilk@oracle.com \ --cc=roger.pau@citrix.com \ --cc=sstabellini@kernel.org \ --cc=tim@xen.org \ --cc=wl@xen.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Xen-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \ xen-devel@lists.xenproject.org xen-devel@lists.xen.org public-inbox-index xen-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.xenproject.lists.xen-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git