From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEAE1C433DF for ; Fri, 31 Jul 2020 13:46:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FD36208E4 for ; Fri, 31 Jul 2020 13:46:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="EHOktpnP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FD36208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1VMW-0007nV-TK; Fri, 31 Jul 2020 13:46:16 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k1VMV-0007nI-7Z for xen-devel@lists.xenproject.org; Fri, 31 Jul 2020 13:46:15 +0000 X-Inumbo-ID: 32cc8136-d334-11ea-abb4-12813bfff9fa Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 32cc8136-d334-11ea-abb4-12813bfff9fa; Fri, 31 Jul 2020 13:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1596203173; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=pxLwBaKdI1Rl3eoAeiydUxHAipGDZU34ct9PFuZ7AW8=; b=EHOktpnPjZHgxB/BeetF7YjB7eqP8RKYeMnQeONQDIpCd/H5yXM9or3a jJSb1VyoJnX4Xji3AS7WxMfTWPOk+GdVocGTd3O1I4VW6vY+sktIyt9YG 2mTo2jv77c09hXnoYvlvIOxibZdKFRYTMZcBdo0qINLMD1lE0mgIEPNlR I=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: qp+giJRsKHqCcTL+S4EWbw00jbbstkd2kJCwx3AI6t7t7MaB0Tubjdpo4k1u7Gu4SOep/lg5l/ r6nl5cIsBd1hGXNXRSLnqrK06N5leGZhwthOsPzRmcmpXz0/aj1CvfWCO+sgCKsSU42YsvuN85 cU4g4Bn+nl1okqu7spvFs3Ur79BEHewPy5w+cnuXjlQfbXvHmisUI+E0/IlEL3G4eh4ZxFgrl8 AHS7bmCovLMp9xlf+N8sYfVnMu9XemwZFeJNOBqK1RXrvOHn5Edr4MmcAvXSK0IHn5/IyIK9zH KiY= X-SBRS: 3.7 X-MesageID: 23810049 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.75,418,1589256000"; d="scan'208";a="23810049" Subject: Re: [PATCH] tools/configure: drop BASH configure variable [and 1 more messages] To: Jan Beulich , Ian Jackson References: <20200722113258.3673-1-andrew.cooper3@citrix.com> <20200626170038.27650-1-andrew.cooper3@citrix.com> <880fcc83-875c-c030-bfac-c64477aa3254@suse.com> <24313.55588.61431.336617@mariner.uk.xensource.com> <2c202733-cbff-74e0-30c6-4cba227e7969@suse.com> <24356.5736.297234.341867@mariner.uk.xensource.com> From: Andrew Cooper Message-ID: Date: Fri, 31 Jul 2020 14:46:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Xen-devel , Daniel De Graaf , Wei Liu , Paul Durrant Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 31/07/2020 14:30, Jan Beulich wrote: > On 31.07.2020 15:02, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"): >>> On 29.06.2020 14:05, Ian Jackson wrote: >>>> Jan Beulich writes ("Re: [PATCH] tools/configure: drop BASH configure variable"): >>>>> On 26.06.2020 19:00, Andrew Cooper wrote: >>>>> ... this may or may not take effect on the file system the sources >>>>> are stored on. >>>> In what circumstances might this not take effect ? >>> When the file system is incapable of recording execute permissions? >>> It has been a common workaround for this in various projects that >>> I've worked with to use $(SHELL) to account for that, so the actual >>> permissions from the fs don't matter. (There may be mount options >>> to make everything executable on such file systems, but people may >>> be hesitant to use them.) >> I don't think we support building from sources which have been >> unpacked onto such filesystems. Other projects which might actually >> need to build on Windows or something do do this $(SHELL) thing or an >> equivalent, but I don't think that's us. > It's not unexpected that you think of Windows here, but my thoughts > were more towards building from sources on a CD or DVD, where iirc > execute permissions also don't exist. The latest when we have > out-of-tree builds fully working, this ought to be something that > people should be able to do, imo. (Even without out-of-tree builds, > my "next best" alternative of using a tree of symlinks to build in > would similarly have an issue with the links pointing at a mounted > CD/DVD, if the $(SHELL) wasn't present.) See v2.  I put $(SHELL) in, because it isn't a worthwhile use of our time to continue arguing over this point. ~Andrew