Re: [PATCH v3 0/11] Revive alchemy, pSOS and VxWorks tests

[Richard Weinberger <richard@nod.at>]

----- Ursprüngliche Mail -----
> Von: "Jan Kiszka" <jan.kiszka@siemens.com>
>> ...but it does hook up with smokey, thus will not run as part of
>> xeno-test and our CI. Please fix that - after either resolving the
>> remaining broken tests or disabling them for now. It should be easy to
>> spawn the new tests as separate processes from a smokey instance and
>> visualize their results as part of smokey.
>> 
> 
> BTW, mutex1 from alchemytest fails for me, all other alchemy tests are fine.

Not sure whether this is related, but on Thursday I ran into a bug in rt_mutex_create(),
it returns also positive error numbers.
This seems to be the fix:

diff --git a/lib/alchemy/mutex.c b/lib/alchemy/mutex.c
index f8933858647a..5836af59f05e 100644
--- a/lib/alchemy/mutex.c
+++ b/lib/alchemy/mutex.c
@@ -133,7 +133,7 @@ int rt_mutex_create(RT_MUTEX *mutex, const char *name)
 	pthread_mutexattr_settype(&mattr, PTHREAD_MUTEX_RECURSIVE);
 	/* pthread_mutexattr_setrobust() might not be implemented. */
 	pthread_mutexattr_setrobust(&mattr, PTHREAD_MUTEX_ROBUST_NP);
-	ret = __RT(pthread_mutex_init(&mcb->lock, &mattr));
+	ret = -__RT(pthread_mutex_init(&mcb->lock, &mattr));
 	if (ret) {
 		xnfree(mcb);
 		goto out;

Thanks,
//richard