* [PATCH 1/1] rwsem_down_write_slowpath check if oob() before skipping schedule()
@ 2023-05-30 19:04 Dave Rolenc
2023-05-31 5:27 ` Jan Kiszka
0 siblings, 1 reply; 2+ messages in thread
From: Dave Rolenc @ 2023-05-30 19:04 UTC (permalink / raw)
To: xenomai; +Cc: Dave Rolenc, Russell Johnson
Signed-off-by: Dave Rolenc <dave.rolenc@kratosdefense.com>
---
kernel/locking/rwsem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
index 4cc73e6f8974..cb77bd38cb64 100644
--- a/kernel/locking/rwsem.c
+++ b/kernel/locking/rwsem.c
@@ -1151,7 +1151,7 @@ rwsem_down_write_slowpath(struct rw_semaphore *sem, int state)
owner_state = rwsem_spin_on_owner(sem);
preempt_enable();
- if (owner_state == OWNER_NULL)
+ if (owner_state == OWNER_NULL && running_oob())
goto trylock_again;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] rwsem_down_write_slowpath check if oob() before skipping schedule()
2023-05-30 19:04 [PATCH 1/1] rwsem_down_write_slowpath check if oob() before skipping schedule() Dave Rolenc
@ 2023-05-31 5:27 ` Jan Kiszka
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2023-05-31 5:27 UTC (permalink / raw)
To: Dave Rolenc, xenomai; +Cc: Russell Johnson
On 30.05.23 21:04, Dave Rolenc wrote:
Here should be the commit message that explains the reason for this
change. It will go into git, your patch 0/1 just into the mailing list
archive.
> Signed-off-by: Dave Rolenc <dave.rolenc@kratosdefense.com>
> ---
> kernel/locking/rwsem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c
> index 4cc73e6f8974..cb77bd38cb64 100644
> --- a/kernel/locking/rwsem.c
> +++ b/kernel/locking/rwsem.c
> @@ -1151,7 +1151,7 @@ rwsem_down_write_slowpath(struct rw_semaphore *sem, int state)
> owner_state = rwsem_spin_on_owner(sem);
> preempt_enable();
>
> - if (owner_state == OWNER_NULL)
> + if (owner_state == OWNER_NULL && running_oob())
> goto trylock_again;
> }
>
Since when does EVL allow to call rwsem_down_write from OOB? Isn't that
the actual issues, but in your application?
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-31 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 19:04 [PATCH 1/1] rwsem_down_write_slowpath check if oob() before skipping schedule() Dave Rolenc
2023-05-31 5:27 ` Jan Kiszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).