Re: [PATCH v4 0/3] alias help tweaks

From: Junio C Hamano <gitster@pobox.com>
To: Rasmus Villemoes <rv@rasmusvillemoes.dk>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Duy Nguyen <pclouds@gmail.com>, Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v4 0/3] alias help tweaks
Date: Fri, 12 Oct 2018 12:17:37 +0900	[thread overview]
Message-ID: <xmqq1s8vetv2.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181009115909.16648-1-rv@rasmusvillemoes.dk> (Rasmus Villemoes's message of "Tue, 9 Oct 2018 13:59:06 +0200")

Rasmus Villemoes <rv@rasmusvillemoes.dk> writes:

> v2: Added patches 2 and 3, made "git cmd --help" unconditionally (no
> config option, no delay) redirect to the aliased command's help,
> preserve pre-existing behaviour of the spelling "git help cmd".
>
> v3: Add some additional comments in patch 1 and avoid triggering leak
> checker reports. Use better wording in patch 3.
>
> v4: Reword commit log in patch 1.

Sorry for failing to point it out and let the style carried over to
v4, but the above is insufficient for a cover latter.  Those who
missed an earlier round has no clue what these patches are about,
and there is not even a pointer to find an earlier discussion in the
list archive.

I think the patches are good with the rounds of reviews it went
through, so let's merge it to 'next'.  Here is what I plan to start
the merge message of the series:

     "git cmd --help" when "cmd" is aliased used to only say "cmd is
     aliased to ...".  Now it shows that to the standard error stream
     and runs "git $cmd --help" where $cmd is the first word of the
     alias expansion.

Please do the cover-letter better next time.

Thanks.

>
> Rasmus Villemoes (3):
>   help: redirect to aliased commands for "git cmd --help"
>   git.c: handle_alias: prepend alias info when first argument is -h
>   git-help.txt: document "git help cmd" vs "git cmd --help" for aliases
>
>  Documentation/git-help.txt |  4 ++++
>  builtin/help.c             | 34 +++++++++++++++++++++++++++++++---
>  git.c                      |  3 +++
>  3 files changed, 38 insertions(+), 3 deletions(-)