Re: [PATCH 0/4] Makefile: micro-optimize light non-test builds

From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/4] Makefile: micro-optimize light non-test builds
Date: Tue, 26 Jan 2021 17:38:08 -0800	[thread overview]
Message-ID: <xmqq5z3jyxa7.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <YBCGtd9if0qtuQxx@coredump.intra.peff.net> (Jeff King's message of "Tue, 26 Jan 2021 16:16:37 -0500")

Jeff King <peff@peff.net> writes:

> On Tue, Jan 26, 2021 at 05:07:04PM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> This small series speeds up builds where you just want to get to a
>> working "git" binary, but don't care about running git's own tests, or
>> about making/installing fallbacks for "git svn" et al (which we do
>> even with NO_PERL).
>
> I have to wonder if you really care about non-builtins here. If not,
> then doesn't "make git" do what you want?

I had the same thought, while wondering if all the ugliness in [4/4]
is really worth it.

The steps 2/4 and 3/4 did look like a useful feature, but I wonder
why we even need to introduce NO_TEST_TOOLS in the first place.
Wouldn't it be more natural to arrange them to be built by making
"test::" target depend on them?  IOW, why do we need to have "all::"
(our default) target depend on them?

And if we are not doing [4/4], I suspect [1/4], while it is not bad
as a clean-up, would become less attractive.

So...