Re: [PATCH] name-rev: use generation numbers if available

From: Junio C Hamano <gitster@pobox.com>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: Derrick Stolee <derrickstolee@github.com>,
	Jacob Keller <jacob.keller@gmail.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] name-rev: use generation numbers if available
Date: Mon, 07 Mar 2022 14:52:26 -0800	[thread overview]
Message-ID: <xmqq7d95qst1.fsf@gitster.g> (raw)
In-Reply-To: <CO1PR11MB508949A91933E83A6BE1194FD6089@CO1PR11MB5089.namprd11.prod.outlook.com> (Jacob E. Keller's message of "Mon, 7 Mar 2022 22:30:55 +0000")

"Keller, Jacob E" <jacob.e.keller@intel.com> writes:

> Ok. The problem is that specific test does not behave the same. In fact it *cannot* behave the same because we're trying to test the non-commit-graph flow there. Since i'm dropping it in v3 I won't worry too much about it.

As you said, if you are removing the test, it is a moot point, but I
think what Derrick suggests is to do something like this:

diff --git c/t/t6120-describe.sh w/t/t6120-describe.sh
index c353c21cc8..871bdbbec9 100755
--- c/t/t6120-describe.sh
+++ w/t/t6120-describe.sh
@@ -508,6 +508,7 @@ test_expect_success 'name-rev without commitGraph does not handle non-monotonic
 		cd non-monotonic &&
 
 		rm -rf .git/info/commit-graph* &&
+		sane_unset GIT_TEST_COMMIT_GRAPH &&
 
 		echo "main~3 undefined" >expect &&
 		git name-rev --tags main~3 >actual &&

where you want to decline using the commit-graph feature.  As this
test piece is already in its own subshell, the unsetting will affect
only this one.
