From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org, toon@iotcl.com
Subject: Re: [PATCH v3 0/2] check-attr: add support to work with revisions
Date: Sat, 17 Dec 2022 08:26:28 +0900 [thread overview]
Message-ID: <xmqq8rj7kk0r.fsf@gitster.g> (raw)
In-Reply-To: <20221216093552.3171319-1-karthik.188@gmail.com> (Karthik Nayak's message of "Fri, 16 Dec 2022 10:35:50 +0100")
Karthik Nayak <karthik.188@gmail.com> writes:
> Changes since version 2:
> - Changes to the commit message [1/2] to use more specific terms and to
> be more descriptive.
> - Moved the flag's position in the documentation to be before the unbound
> list of non-options.
>
> Range-diff against v2:
>
> 1: 2e71cbbddd < -: ---------- Git 2.39-rc2
> -: ---------- > 1: 57e2c6ebbe Start the 2.40 cycle
Does this new iteration use something that was added between these
two bases? Asking because the choice of new base is questionable.
I would understand it if the rebase were on top of v2.39.0 tag,
though.
* If the updated series depends on new APIs and features added
since the old base, do rebase on the new one to take advantage of
them.
* A bugfix patch series may want to avoid using the newest and
greatest if it allows the series to be applied to the older
maintenance track, and keeping the older base may make more
sense.
* If a series based on an older base no longer merges cleanly to
'master' and/or 'next', but rebasing on a newer base makes it
merge cleanly, do rebase.
* Otherwise, keeping the same base is preferred.
When rebasing is appropriate, choosing a well-known base (e.g. a
tagged release) helps others.
next prev parent reply other threads:[~2022-12-16 23:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 9:35 [PATCH v3 0/2] check-attr: add support to work with revisions Karthik Nayak
2022-12-16 9:35 ` [PATCH v3 1/2] t0003: move setup for `--all` into new block Karthik Nayak
2022-12-16 9:35 ` [PATCH v3 2/2] attr: add flag `-r|--revisions` to work with revisions Karthik Nayak
2022-12-16 23:45 ` Junio C Hamano
2022-12-17 15:23 ` Karthik Nayak
2022-12-21 6:10 ` Toon Claes
2022-12-17 0:33 ` Junio C Hamano
2022-12-17 15:27 ` Karthik Nayak
2022-12-16 16:17 ` [PATCH v3 0/2] check-attr: add support " Ævar Arnfjörð Bjarmason
2022-12-16 22:38 ` Junio C Hamano
2022-12-19 8:45 ` Ævar Arnfjörð Bjarmason
2022-12-16 23:28 ` Junio C Hamano
2022-12-17 14:46 ` Karthik Nayak
2022-12-16 23:26 ` Junio C Hamano [this message]
2022-12-17 14:49 ` Karthik Nayak
2022-12-17 10:53 ` Phillip Wood
2022-12-17 14:52 ` Karthik Nayak
2022-12-19 9:45 ` Ævar Arnfjörð Bjarmason
2022-12-19 13:16 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8rj7kk0r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.