Re: [PATCH] grep: follow conventions for printing paths w/ unusual chars

From: Junio C Hamano <gitster@pobox.com>
To: Matheus Tavares <matheus.bernardino@usp.br>
Cc: asheiduk@gmail.com, git@vger.kernel.org, greg@hurrell.net, l.s.r@web.de
Subject: Re: [PATCH] grep: follow conventions for printing paths w/ unusual chars
Date: Thu, 16 Apr 2020 23:45:54 -0700	[thread overview]
Message-ID: <xmqq8siuwqxp.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <eaae7214925189f562056b1ee6972c05dcf76a32.1587103366.git.matheus.bernardino@usp.br> (Matheus Tavares's message of "Fri, 17 Apr 2020 03:04:03 -0300")

Matheus Tavares <matheus.bernardino@usp.br> writes:

> +	if (opt->relative && opt->prefix_length)
> +		quote_path_relative(filename + tree_name_len, opt->prefix, out);
> +	else
> +		quote_c_style(filename + tree_name_len, out, NULL, 0);

Yup.  This solves the discrepancy reported correctly (i.e. both
sides should do the quoting, the original only quoted when relative,
and the new code corrects the other side).

> +	if (tree_name_len)
> +		strbuf_insert(out, 0, filename, tree_name_len);

I am not quite sure about this part, though.  

Earlier we inserted the latter part of filename (after offset
tree_name_len) to strbuf "out" after quoting, and then we are
prefixing the earlier part of the filename without quoting to that
same "out".  Wouldn't a path ABCDEF (I do not literally mean that
these ascii alphabets need quoting---just imagine each of these
stands for a different letter and some causes the path to be quoted)
with tree_name_len pointing somewhere in the middle be added as (an
analog of) ABC"DEF", i.e. literal prefix with remainder quoted?  I
would (perhaps näively) expect that the whole thing would be placed
inside a dq pair in such a case, even if the prefix part alone would
not require quoting.

Thanks.