From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Bert Wesarg <bert.wesarg@googlemail.com>,
git@vger.kernel.org, Denton Liu <liu.denton@gmail.com>
Subject: Re: [PATCH v2 1/2] format-patch: create leading components of output directory
Date: Tue, 08 Oct 2019 12:23:41 +0900 [thread overview]
Message-ID: <xmqq8spvor7m.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191007210306.GF11529@szeder.dev> ("SZEDER =?utf-8?Q?G?= =?utf-8?Q?=C3=A1bor=22's?= message of "Mon, 7 Oct 2019 23:03:06 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
> On one hand, these object ids won't mean much to anyone who might have
> to debug such a test failure in the future, and on the other these
> tests are about 'git format-patch', not about 'git rev-list'. If the
> check were written like this:
>
> count=$(git rev-list --count master..side) &&
> ls patches >list &&
> test_line_count = $count list
>
> then the error message on failure would look something like this:
>
> test_line_count: line count for list != 3
> 0001-first.patch
> 0002-second.patch
>
> which, I think, would be more useful.
That's nice attention to the detail ;-)
next prev parent reply other threads:[~2019-10-08 3:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 21:26 [PATCH 1/3] format-patch: document and exercise that -o does only create the trailing directory Bert Wesarg
2019-10-02 21:26 ` [PATCH 2/3] format-patch: create output directory including leading components Bert Wesarg
2019-10-03 0:54 ` Junio C Hamano
2019-10-02 21:26 ` [RFC PATCH 3/3] format-patch: use a command to generate the output directory name Bert Wesarg
2019-10-03 0:57 ` Junio C Hamano
2019-10-05 8:43 ` [PATCH v2 1/2] format-patch: create leading components of output directory Bert Wesarg
2019-10-05 8:43 ` [PATCH v2 2/2] [RFC] format-patch: configure a command to generate the output directory name Bert Wesarg
2019-10-06 0:57 ` [PATCH v2 1/2] format-patch: create leading components of output directory Junio C Hamano
2019-10-07 21:03 ` SZEDER Gábor
2019-10-08 3:23 ` Junio C Hamano [this message]
2019-10-08 9:06 ` Bert Wesarg
2019-10-08 9:14 ` [PATCH] t4014: treat rev-list output as the expected value Denton Liu
2019-10-02 21:47 ` [PATCH 1/3] format-patch: document and exercise that -o does only create the trailing directory Denton Liu
2019-10-03 16:34 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8spvor7m.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.