All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: [PATCH] repack: document there is no need to avoid delta-base-offset
Date: Tue, 19 Jul 2022 14:48:26 -0700	[thread overview]
Message-ID: <xmqqbktk93kl.fsf_-_@gitster.g> (raw)
In-Reply-To: <220719.8635exwje8.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Tue, 19 Jul 2022 11:07:29 +0200")

As continued use of 1.4.4 by people stopped being an issue long time
ago, we can safely remove the warning about interoperability that we
added in 1.6.0 when the use of delta-base-offset has become default.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

 * Instead of outright removing, it probably is a good idea to hint
   the reason why the now seemingly useless configuration variable
   is there, perhaps.

 Documentation/git-repack.txt | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git c/Documentation/git-repack.txt w/Documentation/git-repack.txt
index 0bf13893d8..882904fc7b 100644
--- c/Documentation/git-repack.txt
+++ w/Documentation/git-repack.txt
@@ -218,15 +218,11 @@ CONFIGURATION
 Various configuration variables affect packing, see
 linkgit:git-config[1] (search for "pack" and "delta").
 
-By default, the command passes `--delta-base-offset` option to
-'git pack-objects'; this typically results in slightly smaller packs,
-but the generated packs are incompatible with versions of Git older than
-version 1.4.4. If you need to share your repository with such ancient Git
-versions, either directly or via the dumb http protocol, then you
-need to set the configuration variable `repack.UseDeltaBaseOffset` to
-"false" and repack. Access from old Git versions over the native protocol
-is unaffected by this option as the conversion is performed on the fly
-as needed in that case.
+By default, the command passes `--delta-base-offset` option to 'git
+pack-objects', which results in packs smaller by a few per-cent.
+The configuration variable `repack.UseDeltaBaseOffset` can be set to
+`false` to disable it, but these days there hardly is any reason to
+do so.
 
 Delta compression is not used on objects larger than the
 `core.bigFileThreshold` configuration variable and on files with the

  reply	other threads:[~2022-07-19 21:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15  7:51 [PATCH] git-repack doc: remove discussion of ancient caveat Ævar Arnfjörð Bjarmason
2022-07-15 16:53 ` Junio C Hamano
2022-07-16  7:59   ` Ævar Arnfjörð Bjarmason
2022-07-18  5:14     ` Junio C Hamano
2022-07-18  7:35       ` Ævar Arnfjörð Bjarmason
2022-07-19  1:16         ` Junio C Hamano
2022-07-19  9:07           ` Ævar Arnfjörð Bjarmason
2022-07-19 21:48             ` Junio C Hamano [this message]
2022-07-19 21:54               ` [PATCH] repack: document there is no need to avoid delta-base-offset Ævar Arnfjörð Bjarmason
2022-07-19 22:20                 ` Junio C Hamano
2022-07-19  0:09 ` [PATCH v2] docs: remove pre-v1.6.0 "repack --delta-base-offset" docs Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbktk93kl.fsf_-_@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.