From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>
Subject: Re: [PATCH 0/2] Trivial cleanups
Date: Tue, 15 Jun 2021 10:45:45 +0900 [thread overview]
Message-ID: <xmqqbl87zyra.fsf@gitster.g> (raw)
In-Reply-To: <20210613063702.269816-1-felipe.contreras@gmail.com> (Felipe Contreras's message of "Sun, 13 Jun 2021 01:37:00 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> These perfeclty good patches from 2014 weren't picked with no good
> reason.
These are safe no-op changes, but that does not mean they are good
patches. It goes against Documentation/CodingGuidelines to bring it
back again now, which is a good enough reason not to look at them.
next prev parent reply other threads:[~2021-06-15 2:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 6:37 [PATCH 0/2] Trivial cleanups Felipe Contreras
2021-06-13 6:37 ` [PATCH 1/2] config: avoid yoda conditions Felipe Contreras
2021-06-13 6:37 ` [PATCH 2/2] add: avoid yoda condition Felipe Contreras
2021-06-15 1:45 ` Junio C Hamano [this message]
2021-06-15 8:22 ` [PATCH 0/2] Trivial cleanups Felipe Contreras
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 17:15 Bjorn Helgaas
2009-11-24 7:24 Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbl87zyra.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.