Re: [PATCH v6] [GSOC] ref-filter: fix read invalid union member bug

From: Junio C Hamano <gitster@pobox.com>
To: "ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	ZheNing Hu <adlternative@gmail.com>
Subject: Re: [PATCH v6] [GSOC] ref-filter: fix read invalid union member bug
Date: Thu, 13 May 2021 08:24:20 +0900	[thread overview]
Message-ID: <xmqqfsyredsr.fsf@gitster.g> (raw)
In-Reply-To: <pull.949.v6.git.1620821572126.gitgitgadget@gmail.com> (ZheNing Hu via GitGitGadget's message of "Wed, 12 May 2021 12:12:51 +0000")

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +test_expect_success '%(color:#aa22ac) must succeed' '
> +	mkdir test &&

You do not need "mkdir test" here, as "git init test" would take
care of it.

On the other hand, you'd want to get 'test' directory removed after
this passes, so 

	test_when_finished rm -fr test &&

would be useful.

Other than that, looks good to me.

Thanks.

> +	git init test &&
> +	(
> +		cd test &&
> +		test_commit initial &&
> +		git branch -M main &&
> +		cat >expect <<-\EOF &&
> +		refs/heads/main
> +		refs/tags/initial
> +		EOF
> +		git remote add origin nowhere &&
> +		git config branch.main.remote origin &&
> +		git config branch.main.merge refs/heads/main &&
> +		git for-each-ref --format="%(color:#aa22ac)%(refname)" >actual &&
> +		test_cmp expect actual
> +	)
> +'
> +
>  test_expect_success 'left alignment is default' '
>  	cat >expect <<-\EOF &&
>  	refname is refs/heads/main    |refs/heads/main
>
> base-commit: 311531c9de557d25ac087c1637818bd2aad6eb3a