Re: [RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface

From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface
Date: Mon, 26 Nov 2018 15:45:01 +0900	[thread overview]
Message-ID: <xmqqh8g4xrpu.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <5841455b55d7e14f962659ce3bf36c1f04162268.1543143503.git.carenas@gmail.com> ("Carlo Marcelo Arenas =?utf-8?Q?Bel=C3=B3n=22's?= message of "Sun, 25 Nov 2018 03:06:47 -0800")

Carlo Marcelo Arenas Belón  <carenas@gmail.com> writes:

> prevents the following warning :

s/^/Doing so / or something to make it a complete sentence.

> ...
> it is set by optional configure at least since NetBSD 6.0

s/it/It/;

Again, makes sense, and thanks for tying this loose end.

> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 36c973c7e6..59ce03819b 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -246,6 +246,7 @@ ifeq ($(uname_S),NetBSD)
>  	ifeq ($(shell expr "$(uname_R)" : '[01]\.'),2)
>  		NEEDS_LIBICONV = YesPlease
>  	endif
> +	OLD_ICONV = UnfortunatelyYes
>  	BASIC_CFLAGS += -I/usr/pkg/include
>  	BASIC_LDFLAGS += -L/usr/pkg/lib $(CC_LD_DYNPATH)/usr/pkg/lib
>  	USE_ST_TIMESPEC = YesPlease