Re: [PATCH v2] cache-tree: skip some blob checks in partial clone

From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, peartben@gmail.com
Subject: Re: [PATCH v2] cache-tree: skip some blob checks in partial clone
Date: Wed, 10 Oct 2018 10:19:18 +0900	[thread overview]
Message-ID: <xmqqh8huoay1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20181009184037.246871-1-jonathantanmy@google.com> (Jonathan Tan's message of "Tue, 9 Oct 2018 11:40:37 -0700")

Jonathan Tan <jonathantanmy@google.com> writes:

> After feedback, I restricted this to partial clone. Once restricted, I
> agree with Ben that this can be done for all users of
> cache_tree_update(), not just unpack-trees, so I have removed the
> ability to control the behavior using a flag.

Makes sense.  Great.

> I also took the opportunity to simplify the missing check by using a
> variable.
>  
> +		ce_missing_ok = mode == S_IFGITLINK || missing_ok ||
> +			(repository_format_partial_clone &&
> +			 ce_skip_worktree(ce));
>  		if (is_null_oid(oid) ||
> -		    (mode != S_IFGITLINK && !missing_ok && !has_object_file(oid))) {
> +		    (!ce_missing_ok && !has_object_file(oid))) {

OK.  "An attempt to check out null object is bad, and otherwise,
unless we determined that it is OK to lack the object recorded in
ce, it is bad too.  By the way, the way we determine if it is OK to
be missing the object is given above".  Easier to read than the
original.