Re: [PATCH] gitk: Make web links clickable

From: Junio C Hamano <gitster@pobox.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: Make web links clickable
Date: Tue, 27 Aug 2019 13:32:30 -0700	[thread overview]
Message-ID: <xmqqimqi2vtt.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190826221444.GB7402@blackberry> (Paul Mackerras's message of "Tue, 27 Aug 2019 08:14:44 +1000")

Paul Mackerras <paulus@ozlabs.org> writes:

> This makes gitk look for lines in the commit message which start with
> "Link:" or "BugLink:" followed by a http or https URL, and make the
> URL clickable.  Clicking on it will invoke an external web browser with
> the URL.
>
> The web browser command is by default "xdg-open" on Linux, "open" on
> MacOS, and "cmd /c start" on Windows.  The command can be changed in
> the preferences window, and it can include parameters as well as the
> command name.  If it is set to the empty string then URLs will no
> longer be made clickable.
>
> Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
> ---

>  gitk | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/gitk b/gitk
> index a14d7a1..4577150 100755
> --- a/gitk
> +++ b/gitk
> @@ -7016,6 +7016,7 @@ proc commit_descriptor {p} {
>  
>  # append some text to the ctext widget, and make any SHA1 ID
>  # that we know about be a clickable link.
> +# Also look for lines of the form "Link: http..." and make them web links.

FWIW, I personally hate those "Link:" that do not say what the links
are for (IOW, I am OK with "BugLink:" or even "Bug:").

In any case, I polled your repository but I did not find anything to
pull.  Do you want me to start my own gitk mirror, queue this patch
there and pull from it myself, or is this meant to be a preview of
what you'll tell me to pull in a few days?

Thanks.