From: Junio C Hamano <gitster@pobox.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
git@vger.kernel.org,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Thomas Gummerer" <t.gummerer@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
lucas.de.marchi@gmail.com
Subject: Re: [PATCH] range-diff: allow to diff files regardless submodule
Date: Wed, 24 Oct 2018 14:18:43 +0900 [thread overview]
Message-ID: <xmqqk1m7orbg.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqtvlcnd1w.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Wed, 24 Oct 2018 14:12:11 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> Lucas De Marchi <lucas.demarchi@intel.com> writes:
>
>> Your reply arrived just a little after I sent the v2, so I thought it
>> was just the race and you would end up seeing the unread email in the
>> same thread. Sorry for not including the msg id:
>> 20181011081750.24240-1-lucas.demarchi@intel.com
>
> OK, then I am not surprised that I do not recall seeing such an old
> message ;-) Let me take a look.
Heh, it turns out that that is the version that has been queued in
'next' for about a week already.
One issue that was pointed out in v1 was that the log message was
unclear; it seems v2 didn't address that at all, though.
Thanks.
next prev parent reply other threads:[~2018-10-24 5:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 15:09 [PATCH] range-diff: allow to diff files regardless submodule Lucas De Marchi
2018-10-11 0:02 ` brian m. carlson
2018-10-11 7:50 ` Lucas De Marchi
2018-10-12 9:24 ` Johannes Schindelin
2018-10-12 23:17 ` brian m. carlson
2018-10-11 7:42 ` Ævar Arnfjörð Bjarmason
2018-10-11 8:14 ` Lucas De Marchi
2018-10-11 8:17 ` [PATCH v2] " Lucas De Marchi
2018-10-12 9:26 ` Johannes Schindelin
2018-10-11 8:25 ` [PATCH] " Junio C Hamano
2018-10-23 14:07 ` Lucas De Marchi
2018-10-24 2:12 ` Junio C Hamano
2018-10-24 2:43 ` Lucas De Marchi
2018-10-24 5:12 ` Junio C Hamano
2018-10-24 5:18 ` Junio C Hamano [this message]
2018-10-24 17:19 ` Lucas De Marchi
2018-10-24 19:46 ` [PATCH v3] range-diff: allow to diff files regardless of submodule config Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqk1m7orbg.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=sunshine@sunshineco.com \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.