Re: [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions

From: Junio C Hamano <gitster@pobox.com>
To: "Sanchit Jindal via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Sanchit Jindal <sanchit1053@gmail.com>
Subject: Re: [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
Date: Wed, 20 Mar 2024 13:46:06 -0700	[thread overview]
Message-ID: <xmqqle6cfx81.fsf@gitster.g> (raw)
In-Reply-To: <pull.1700.git.1710964109659.gitgitgadget@gmail.com> (Sanchit Jindal via GitGitGadget's message of "Wed, 20 Mar 2024 19:48:29 +0000")

"Sanchit Jindal via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: sanchit1053 <sanchit1053@gmail.com>
>
> Signed-off-by: sanchit1053 <sanchit1053@gmail.com>
> ---

>     t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
>     
>     I have updated the statements test [!] -[e|f] with the corresponding
>     test_path_* functions The statements are at the end of their respective
>     texts and can be easily replaced
>     
>     I am having trouble with the git send-email and my institutes firewall,
>     that is why I am trying to use gitgitgadget

A few minor points.

 * As our test numbers uniquely identify test scripts, your commit
   title can be "t9803: use test_path_* helpers".

 * We prefer to see the patches signed with real name.  As you seem
   to have let your name known to GGG, I am assuming "sanchit1053"
   is not a name you chose for anonymity.  You would want to, at
   least while you are working for this project, have something like

     $ git config user.name "Sanchit Jindal"

   in the repository you use to work on Git.

 * The proposed commit log message is empty; you seem to have a lot
   more after the three-dash lines, which probably came from pull
   request message you gave GGG.  The single paragraph that talks
   about "test [!] -[e|f]" should go between From: and Signed-off-by:
   but refer to Documentation/SubmittingPatches:[[describe-changes]]
   while reading the message again and updating it.

The patch text below looks good to me (but that is to be
expected---a microproject is not a practice about coding, but is
a practice about interacting with reviewers and going through a
contribution process).

Thanks.

>  t/t9803-git-p4-shell-metachars.sh | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/t/t9803-git-p4-shell-metachars.sh b/t/t9803-git-p4-shell-metachars.sh
> index 2913277013d..4905ed2ae9e 100755
> --- a/t/t9803-git-p4-shell-metachars.sh
> +++ b/t/t9803-git-p4-shell-metachars.sh
> @@ -33,8 +33,8 @@ test_expect_success 'shell metachars in filenames' '
>  	(
>  		cd "$cli" &&
>  		p4 sync ... &&
> -		test -e "file with spaces" &&
> -		test -e "foo\$bar"
> +		test_path_exists "file with spaces" &&
> +		test_path_exists "foo\$bar"
>  	)
>  '
>  
> @@ -52,8 +52,8 @@ test_expect_success 'deleting with shell metachars' '
>  	(
>  		cd "$cli" &&
>  		p4 sync ... &&
> -		test ! -e "file with spaces" &&
> -		test ! -e foo\$bar
> +		test_path_is_missing "file with spaces" &&
> +		test_path_is_missing foo\$bar
>  	)
>  '
>  
> @@ -100,8 +100,8 @@ test_expect_success 'branch with shell char' '
>  		git p4 clone --dest=. --detect-branches //depot@all &&
>  		git log --all --graph --decorate --stat &&
>  		git reset --hard p4/depot/branch\$3 &&
> -		test -f shell_char_branch_file &&
> -		test -f f1
> +		test_path_is_file shell_char_branch_file &&
> +		test_path_is_file f1
>  	)
>  '
>  
>
> base-commit: 3bd955d26919e149552f34aacf8a4e6368c26cec