Re: [PATCH v3] use delete_refs when deleting tags or branches

From: Junio C Hamano <gitster@pobox.com>
To: Phil Hord <phil.hord@gmail.com>
Cc: Git <git@vger.kernel.org>,
	"Martin Ågren" <martin.agren@gmail.com>,
	"Elijah Newren" <newren@gmail.com>
Subject: Re: [PATCH v3] use delete_refs when deleting tags or branches
Date: Thu, 21 Jan 2021 18:17:16 -0800	[thread overview]
Message-ID: <xmqqlfclaf6b.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CABURp0pqdK+Mrqi=r40YeUitaB2s44iYO=2UFFSh0UC_o4Mosg@mail.gmail.com> (Phil Hord's message of "Thu, 21 Jan 2021 16:27:22 -0800")

Phil Hord <phil.hord@gmail.com> writes:

> Oof.  Sorry.  I forgot I have diff.noprefix=true in my local config.
> It is a huge timesaver for me when looking at diffs on a console since
> I can quickly highlight the filename with a mouse to paste into an
> editor.
>
> Sometimes it bites me, though.  Usually I notice in the diff, but this
> one I was sending with format-patch / send-email.
>
> I guess I'll turn that off in git.git so I don't misfire at you again someday.

I think per-repository configuration might be sufficient for this
particular case (after all, it is project's preference), I wonder if
a more command-specific variant of diff.noprefix so that "log -p"
and "format-patch" can be configured separately would make sense,
something like...

    [diff]
	noprefix = true
    [diff "format-patch"]
	noprefix = false
    [diff "show"]
	noprefix = false