Re: [PATCH v4] diff: add config option relative

From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: Laurent Arnoud <laurent@spkdev.net>,
	phillip.wood@dunelm.org.uk,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	git@vger.kernel.org
Subject: Re: [PATCH v4] diff: add config option relative
Date: Sun, 17 May 2020 08:12:58 -0700	[thread overview]
Message-ID: <xmqqlflq7fyd.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200517021452.GA2114@danh.dev> (=?utf-8?B?IsSQb8OgbiBUcg==?= =?utf-8?B?4bqnbiBDw7RuZw==?= Danh"'s message of "Sun, 17 May 2020 09:14:52 +0700")

Đoàn Trần Công Danh  <congdanhqx@gmail.com> writes:

>>  Documentation/config/diff.txt   |  4 ++
>>  Documentation/diff-options.txt  |  3 ++
>>  diff.c                          | 16 ++++--
>>  t/t9904-diff-relative-config.sh | 93 +++++++++++++++++++++++++++++++++
>
> I think t99?? is used for miscellaneous tests.
>
> To me, diff-relative things should be tested in t4045-diff-relative.sh

Right.  Thanks for carefully checking what we already have.

>> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
>> index bb31f0c42b..1b279904eb 100644
>> --- a/Documentation/diff-options.txt
>> +++ b/Documentation/diff-options.txt
>> @@ -651,6 +651,9 @@ ifndef::git-format-patch[]
>>  	not in a subdirectory (e.g. in a bare repository), you
>>  	can name which subdirectory to make the output relative
>>  	to by giving a <path> as an argument.
>> +--no-relative::
>
> Please merge this option with `--relative[=<path>]` above.
> And says something likes:
>
> 	`--no-relative` can be used to countermand
> 	both `diff.relative` and previous `--relative`

This, and all the rest of comments are quite good.  Thanks for helping.