From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Taylor Blau <me@ttaylorr.com>,
git@vger.kernel.org, Matheus Tavares <matheus.bernardino@usp.br>
Subject: Re: [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH
Date: Mon, 14 Sep 2020 14:37:12 -0700 [thread overview]
Message-ID: <xmqqo8m811mf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200912195256.GN241078@camp.crustytoothpaste.net> (brian m. carlson's message of "Sat, 12 Sep 2020 19:52:56 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
>> Alternatively, I certainly wouldn't complain if you did introduce a new
>> function and updated the call-site that passes reinit as 1.
>
> I thought about introducing a new function, but since it would share
> almost all of the code, it seemed a bit wasteful, even if the function
> is small. We do have only two callers, I believe, since I recall
> making this function non-static and calling it from clone, so I think
> it's okay.
Perhaps.
FWIW, this seems to have strange interaction with something in
'seen' when merged; I suspect it is the topic that mucks with the
set-up sequence for "git clone", but didn't check.
next prev parent reply other threads:[~2020-09-14 21:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:17 Posible bug with GIT_DEFAULT_HASH during clone Matheus Tavares
2020-09-11 23:20 ` brian m. carlson
2020-09-11 23:38 ` [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH brian m. carlson
2020-09-12 3:24 ` Taylor Blau
2020-09-12 19:52 ` brian m. carlson
2020-09-14 21:37 ` Junio C Hamano [this message]
2020-09-14 21:44 ` Junio C Hamano
2020-09-15 1:32 ` brian m. carlson
2020-09-15 1:58 ` [PATCH v2] " brian m. carlson
2020-09-15 4:31 ` Junio C Hamano
2020-09-15 22:51 ` brian m. carlson
2020-09-20 22:35 ` [PATCH v3] " brian m. carlson
2020-09-21 4:27 ` Junio C Hamano
2020-09-22 9:17 ` brian m. carlson
2020-09-22 16:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8m811mf.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.