Re: [PATCH v2 10/24] t/helper: initialize repository if necessary

From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH v2 10/24] t/helper: initialize repository if necessary
Date: Mon, 24 Feb 2020 10:05:55 -0800	[thread overview]
Message-ID: <xmqqo8tnrhbw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20200222201749.937983-11-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sat, 22 Feb 2020 20:17:35 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> The repository helper is used in t5318 to read commit graphs whether
> we're in a repository or not. However, without a repository, we have no
> way to properly initialize the hash algorithm, meaning that the file is
> misread.
>
> Fix this by calling setup_git_directory_gently, which will read the
> environment variable the testsuite sets to ensure that the correct hash
> algorithm is set.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  t/helper/test-repository.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/t/helper/test-repository.c b/t/helper/test-repository.c
> index f7f8618445..ecc768e4cb 100644
> --- a/t/helper/test-repository.c
> +++ b/t/helper/test-repository.c
> @@ -75,6 +75,10 @@ static void test_get_commit_tree_in_graph(const char *gitdir,
>  
>  int cmd__repository(int argc, const char **argv)
>  {
> +	int nongit_ok = 0;
> +
> +	setup_git_directory_gently(&nongit_ok);

No need to initialize nongit_ok to any specific value before calling
setup_git_directory_gently() and I personally find this initialization
unhelpful to new readers, as it misleadingly hints the setup process
may be affected by the value passed in by the value in nongit_ok,
when in reality the variable is purely used as outout-only (the
first thing the function does is to clear it).

Was it necessary to work around a compiler warning or something?

>  	if (argc < 2)
>  		die("must have at least 2 arguments");
>  	if (!strcmp(argv[1], "parse_commit_in_graph")) {