From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Davide Berardi <davide.berardi6@unibo.it>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH v2] clone: Don't segfault on -b specifing a non-commit
Date: Wed, 06 Nov 2019 18:53:02 +0900 [thread overview]
Message-ID: <xmqqo8xptjpd.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191106040523.GB4307@sigill.intra.peff.net> (Jeff King's message of "Tue, 5 Nov 2019 23:05:23 -0500")
Jeff King <peff@peff.net> writes:
> If we did want to handle it, though, I think it would be easy with the
> setup I described; update_head() could check is_null_oid() itself.
Yup, that was what I had in my review on the previous round ;-)
prev parent reply other threads:[~2019-11-06 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 0:24 [PATCH] Segmentation Fault on non-commit --branch clone Davide Berardi
2019-11-01 19:08 ` Johannes Schindelin
2019-11-01 19:35 ` Jeff King
2019-11-02 10:16 ` Junio C Hamano
2019-11-03 18:16 ` Davide Berardi
2019-11-04 3:55 ` Junio C Hamano
2019-11-02 9:18 ` Junio C Hamano
2019-11-01 19:43 ` Jeff King
2019-11-02 10:07 ` Junio C Hamano
2019-11-03 18:07 ` [PATCH v2] clone: Don't segfault on -b specifing a non-commit Davide Berardi
2019-11-05 4:37 ` Jeff King
2019-11-06 1:36 ` Junio C Hamano
2019-11-06 4:05 ` Jeff King
2019-11-06 9:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8xptjpd.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=davide.berardi6@unibo.it \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.