From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 01/23] contrib/coccinnelle: add equals-null.cocci
Date: Sat, 30 Apr 2022 13:56:40 -0700 [thread overview]
Message-ID: <xmqqpmky70jb.fsf@gitster.g> (raw)
In-Reply-To: <6e8cd958-b749-0a55-d8ae-ff249f06bd2f@iee.email> (Philip Oakley's message of "Sat, 30 Apr 2022 20:34:45 +0100")
Philip Oakley <philipoakley@iee.email> writes:
> On 30/04/2022 05:13, Elia Pinto wrote:
>> Add a coccinelle semantic patch necessary to reinforce the git coding style
>> guideline:
>>
>> "Do not explicitly compute an integral value with constant 0 or '\ 0', or a
>
> s/compute/compare/
>> pointer value with constant NULL."
>
> If this gets re-rolled, perhaps include a simple example for those who
> don't immediately understand that quoted sentence. It will also help
> decode the coccinelle script
>
> so: `if (ptr == NULL)` becomes `if (!ptr)` etc.
That is certainly a good suggestion, but I am wondering if we want
to also emphasize another more generally applicable rule that
appears much earlier in the guideline document:
- Fixing style violations while working on a real change as a
preparatory clean-up step is good, but otherwise avoid useless code
churn for the sake of conforming to the style.
"Once it _is_ in the tree, it's not really worth the patch noise to
go and fix it up."
Cf. http://lkml.iu.edu/hypermail/linux/kernel/1001.3/01069.html
next prev parent reply other threads:[~2022-04-30 20:56 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 4:13 [PATCH 00/23] add a new coccinelle semantic patch to enforce a Elia Pinto
2022-04-30 4:13 ` [PATCH 01/23] contrib/coccinnelle: add equals-null.cocci Elia Pinto
2022-04-30 19:34 ` Philip Oakley
2022-04-30 20:56 ` Junio C Hamano [this message]
2022-04-30 21:38 ` Philip Oakley
2022-04-30 23:13 ` Junio C Hamano
2022-05-01 0:20 ` Junio C Hamano
2022-05-01 17:04 ` Elia Pinto
2022-05-01 17:22 ` Philip Oakley
2022-05-01 23:14 ` Junio C Hamano
2022-05-01 23:37 ` Elia Pinto
2022-05-02 6:22 ` Junio C Hamano
2022-05-02 10:00 ` Philip Oakley
2022-05-02 16:32 ` Junio C Hamano
2022-05-02 11:07 ` Carlo Marcelo Arenas Belón
2022-04-30 4:13 ` [PATCH 02/23] apply.c: Fix coding style Elia Pinto
2022-04-30 4:13 ` [PATCH 03/23] archive.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 04/23] blame.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 05/23] branch.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 06/23] builtin/bisect--helper.c: " Elia Pinto
2022-05-03 9:54 ` Christian Couder
2022-04-30 4:13 ` [PATCH 07/23] builtin/checkout.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 08/23] builtin/clone.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 09/23] builtin/commit.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 10/23] builtin/diff.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 11/23] builtin/gc.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 12/23] builtin/index-pack.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 13/23] builtin/log.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 14/23] builtin/ls-remote.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 15/23] builtin/mailsplit.c: " Elia Pinto
2022-04-30 4:13 ` [PATCH 16/23] builtin/pack-redundant.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 17/23] builtin/receive-pack.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 18/23] builtin/replace.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 19/23] builtin/rev-parse.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 20/23] builtin/shortlog.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 21/23] builtin/tag.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 22/23] combine-diff.c: " Elia Pinto
2022-04-30 4:14 ` [PATCH 23/23] commit-graph.c: " Elia Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmky70jb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=philipoakley@iee.email \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.