From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH 0/3] commit: add an option to reword the last commit
Date: Mon, 21 Sep 2020 09:15:51 -0700 [thread overview]
Message-ID: <xmqqr1qvf6mg.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <pull.736.git.1600695050.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Mon, 21 Sep 2020 13:30:47 +0000")
"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:
> If one notices a typo in the last commit after starting to stage changes for
> the next commit it is useful to be able to reword the last commit without
> changing its contents. Currently the way to do that is by specifying --amend
> --only with no pathspec which is not that obvious to new users (so much so
> that before beb635ca9c ("commit: remove 'Clever' message for --only
> --amend", 2016-12-09) commit printed a message to congratulate the user on
> figuring out how to do it).
;-)
"git commit --only --amend" could already be read as an instruction
that "I am only amending without changing anything else", but I
agree that the new --reword verb is a good addition.
The only comment I had on the series was that the mutual-exclusivity
logic looked a bit fragile against feature evolution of the command,
but I have no concrete suggestion to make it more robust against
time.
prev parent reply other threads:[~2020-09-21 16:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 13:30 [PATCH 0/3] commit: add an option to reword the last commit Phillip Wood via GitGitGadget
2020-09-21 13:30 ` [PATCH 1/3] commit docs: use backquotes when quoting options Phillip Wood via GitGitGadget
2020-09-21 13:30 ` [PATCH 2/3] commit: reorder synopsis Phillip Wood via GitGitGadget
2020-09-22 5:27 ` Junio C Hamano
2020-09-22 13:27 ` Phillip Wood
2020-09-22 16:16 ` Junio C Hamano
2020-09-21 13:30 ` [PATCH 3/3] commit: add an option the reword HEAD Phillip Wood via GitGitGadget
2020-09-21 15:43 ` Eric Sunshine
2020-09-21 18:05 ` Phillip Wood
2020-09-21 18:12 ` Eric Sunshine
2020-09-21 19:27 ` Junio C Hamano
2020-09-22 13:38 ` Phillip Wood
2020-09-22 16:54 ` Junio C Hamano
2020-09-21 17:04 ` Christian Couder
2020-09-21 18:01 ` Phillip Wood
2020-09-23 10:22 ` Johannes Schindelin
2020-09-23 18:23 ` Phillip Wood
2020-09-23 20:42 ` Johannes Schindelin
2020-09-24 9:58 ` Phillip Wood
2020-09-24 16:58 ` Junio C Hamano
2020-09-21 16:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr1qvf6mg.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.