From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: 16657101987@163.com, git@vger.kernel.org, mhagger@alum.mit.edu,
sunchao9@huawei.com, worldhello.net@gmail.com
Subject: Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file
Date: Mon, 19 Aug 2019 10:36:25 -0700 [thread overview]
Message-ID: <xmqqr25hxdk6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190816204906.GA29853@sigill.intra.peff.net> (Jeff King's message of "Fri, 16 Aug 2019 16:49:06 -0400")
Jeff King <peff@peff.net> writes:
> I'm undecided on this. I think reftables are still a while off, and even
> once they are here, many people will still be using the older format. So
> it makes sense to still apply fixes to the old code.
Yeah.
> What I wonder, though, is whether always refreshing will cause a
> noticeable performance impact (and that's why I was so slow in
> responding -- I had hoped to try to come up with some numbers, but I
> just hadn't gotten around to it).
>
> My gut says it's _probably_ not an issue, but it would be nice to have
> some data to back it up.
I am tempted to let correctness (and ease-of-reasoning about the
code) take precedence over potential and unknown performance issue,
at least for now. A single liner is rather simple to revert (or in
the worst case we could add "allow pack-refs to efficiently lose a
ref to a race" configuration option) anyway.
next prev parent reply other threads:[~2019-08-19 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-21 18:17 [PATCH v1 0/1] pack-refs: pack expired loose refs to packed_refs 16657101987
2019-07-21 18:17 ` [PATCH v1 1/1] " 16657101987
2019-07-30 6:36 ` Jeff King
2019-07-31 18:35 ` [PATCH v2 0/1] pack-refs: always refreshing after take the lock file 16657101987
2019-07-31 18:35 ` [PATCH v2 1/1] " 16657101987
2019-08-16 20:49 ` [PATCH v2 0/1] " Jeff King
2019-08-19 17:36 ` Junio C Hamano [this message]
2019-08-20 15:14 ` 16657101987
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqr25hxdk6.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=16657101987@163.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
--cc=sunchao9@huawei.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.