Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()

From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Jeff King <peff@peff.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Johannes Sixt <j6t@kdbg.org>,
	gitgitgadget@gmail.com, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] mingw: handle absolute paths in expand_user_path()
Date: Mon, 12 Nov 2018 12:03:43 +0900	[thread overview]
Message-ID: <xmqqr2fr3skw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8BzbEnXMRw6kB1rg+WMfu2wwJZWkAtVate98CZRSY_dLA@mail.gmail.com> (Duy Nguyen's message of "Fri, 9 Nov 2018 17:16:41 +0100")

Duy Nguyen <pclouds@gmail.com> writes:

> FWIW I don't have any preference, as long as the variable can still
> have a name (that is not a symbol).

Same here.

> A side question regardless of syntax. What do we do with
> %(unrecognized name)/foo? I see three options
>
>  - expand to empty, so "/foo"
>  - keep it and try the literal path "%(unrecognized name)/foo"

Neither of these is good for future proofing purposes.

>  - somehow tell the caller that the path is invalid and treat it like
> non-existing path, even if there is some real thing at "%(unrecognized
> name)/foo"

Another thing to worry about is how to spell the real thing that has
such a funny name, perhaps by escaping like "%%(unrecognized
name)/foo".

And from that point of view, "~runtime-prefix~/foo" (i.e. what J6t
started) may make the most sense, as I do not think we need to
support a username that ends with a tilde by introducing a quoting
convention.