From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] test-lib: allow test snippets as here-docs
Date: Fri, 09 Apr 2021 15:56:29 -0700 [thread overview]
Message-ID: <xmqqtuofkqxu.fsf@gitster.g> (raw)
In-Reply-To: <YHDVAxxKDzfTlq3h@coredump.intra.peff.net> (Jeff King's message of "Fri, 9 Apr 2021 18:28:19 -0400")
Jeff King <peff@peff.net> writes:
> + If <script> is `-` (a single dash), then the script to run is read
> + from stdin. This lets you more easily use single quotes within the
> + script by using a here-doc. For example:
> +
> + test_expect_success 'output contains expected string' <<-\EOT
Missing '-'?
> + grep "this string has 'quotes' in it" output
> + EOT
> +
> ...
> + # start with a newline, to match hanging newline from open-quote style
> + eval "$1=\$LF"
> + local test_line
> + while IFS= read -r test_line
> + do
> + eval "$1=\${$1}\${test_line}\${LF}"
> + done
I wonder if we can do this without relying on "read -r" (which I
distrust, perhaps out of superstition)? Perhaps by slurping the
whole thing with "$(cat)"?
Thanks.
next prev parent reply other threads:[~2021-04-09 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 22:26 [RFC/PATCH 0/2] here-doc test bodies Jeff King
2021-04-09 22:28 ` [PATCH 1/2] test-lib: allow test snippets as here-docs Jeff King
2021-04-09 22:30 ` Jeff King
2021-04-09 22:56 ` Junio C Hamano [this message]
2021-04-10 0:57 ` Junio C Hamano
2021-04-10 1:26 ` Jeff King
2021-04-10 8:30 ` Ævar Arnfjörð Bjarmason
2021-04-09 22:28 ` [PATCH 2/2] t1404: convert to here-doc test bodies Jeff King
2021-04-10 1:03 ` [RFC/PATCH 0/2] " Derrick Stolee
2021-04-10 1:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqtuofkqxu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.