Re: [PATCH] clean: improve -n and -f implementation and documentation

From: Junio C Hamano <gitster@pobox.com>
To: Sergey Organov <sorganov@gmail.com>
Cc: "Jean-Noël AVILA" <avila.jn@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] clean: improve -n and -f implementation and documentation
Date: Sat, 02 Mar 2024 13:07:52 -0800	[thread overview]
Message-ID: <xmqqwmqkwdef.fsf@gitster.g> (raw)
In-Reply-To: <87r0gs8kgw.fsf@osv.gnss.ru> (Sergey Organov's message of "Sat, 02 Mar 2024 23:09:03 +0300")

Sergey Organov <sorganov@gmail.com> writes:

>> Oh, sorry, I misinterpreted the patch. But yet, I'm not sure that
>> specifying that this is the default or not is really useful. If the
>> configuration was set to true, it is was a no-op. If set to false, no
>> message will appear.
>
> I'm not sure either, and as it's not the topic of this particular patch,
> I'd like to delegate the decision on the issue.

It is very much spot on the topic of simplifying and clarifying the
code to unify these remaining two messages into a single one.

And involving the --interactive that allows users a chance to
rethink and refrain from removing some to the equation would also be
worth doing in the same topic, even though it might not fit your
immediate agenda of crusade against --dry-run.