Re: [PATCH v2 0/4] Reactions to v2.37.0-rc0 test coverage report

From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, me@ttaylorr.com,
	Eric Sunshine <sunshine@sunshineco.com>,
	Derrick Stolee <derrickstolee@github.com>
Subject: Re: [PATCH v2 0/4] Reactions to v2.37.0-rc0 test coverage report
Date: Thu, 16 Jun 2022 12:13:24 -0700	[thread overview]
Message-ID: <xmqqy1xws9pn.fsf@gitster.g> (raw)
In-Reply-To: <pull.1261.v2.git.1655385230.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Thu, 16 Jun 2022 13:13:46 +0000")

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> These patches add test coverage or simplify code based on discoveries in the
> test coverage report (specifically, some that I highlighted at [1]).
>
> [1]
> https://lore.kernel.org/git/3d1c6dfd-1df6-3393-df5e-692719375772@github.com/
>
>  1. Add tests for 'git update-index --verbose'.
>  2. Add 'git gc --cruft' without '--prune=now' to test.
>  3. Drop an always-NULL parameter from an internal method.
>  4. Revert 080ab56a4 (cache-tree: implement cache_tree_find_path(),
>     2022-05-23).
>
> Any subset of these could be taken (or dropped), but I thought they would be
> worth considering.
>
>
> Updates in v2
> =============
>
>  * A useless addition of --verbose was removed from a test in patch 1.
>  * Comments are updated in patch 2 based on Taylor's recommendations.
>  * Added --prune="01-01-1980" to exercise the --cruft-expiration logic
>    underneath 'git gc --cruft'.

Thanks.  Queued.