From: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
linux-modules <linux-modules@vger.kernel.org>,
ykaliuta@redhat.com
Subject: Re: [PATCH kmod] libkmod-signature: implement pkcs7 parsing with openssl
Date: Tue, 29 Jan 2019 20:34:43 +0200 [thread overview]
Message-ID: <xunyr2cv71oc.fsf@redhat.com> (raw)
In-Reply-To: <20190129180345.dujswjq2c5lrjajm@ldmartin-desk.jf.intel.com> (Lucas De Marchi's message of "Tue, 29 Jan 2019 10:03:45 -0800")
Hi, Lucas!
>>>>> On Tue, 29 Jan 2019 10:03:45 -0800, Lucas De Marchi wrote:
[...]
>> > yes, my idea was to just leave it simpler and add a
>>
>> > if (pkcs7)
>> > free(key_id)
>>
>> Ah, got it, thanks!
>>
>> Well, if it's not a show stopper for you, I would rather keep it
>> as in the original proposal since it does not inject
>> implementation details to the upper level.
> ok, we may revisit this later. What's the status of the test
> for testsuite?
Haven't checked yet, sorry (caught some flu).
> Are you going to send a v2 (3?) including the test?
Yes if everything finally works.
--
WBR,
Yauheni Kaliuta
prev parent reply other threads:[~2019-01-29 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 13:38 [PATCH kmod] libkmod-signature: implement pkcs7 parsing with openssl Yauheni Kaliuta
2019-01-25 18:33 ` Lucas De Marchi
2019-01-26 11:01 ` Yauheni Kaliuta
2019-01-28 18:05 ` Lucas De Marchi
2019-01-29 9:50 ` Yauheni Kaliuta
2019-01-29 16:50 ` Lucas De Marchi
2019-01-29 17:22 ` Yauheni Kaliuta
2019-01-29 18:03 ` Lucas De Marchi
2019-01-29 18:34 ` Yauheni Kaliuta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xunyr2cv71oc.fsf@redhat.com \
--to=yauheni.kaliuta@redhat.com \
--cc=linux-modules@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=lucas.demarchi@intel.com \
--cc=ykaliuta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.