Re: [meta-arago][kirkstone][PATCH] graphics: kms++: Enable OmapCard support in pykms library

[Andrew Davis <afd@ti.com>]

On 2/13/24 3:27 AM, Sinthu Raja M wrote:
> On Tue, Feb 13, 2024 at 2:17 PM Tomi Valkeinen
> <tomi.valkeinen@ideasonboard.com> wrote:
>>
>> On 13/02/2024 10:28, Devarsh Thakkar wrote:
>>> +Tomi.
>>>
>>> Hi Sinthu, Andrew,
>>>
>>> On 13/02/24 12:11, Sinthu Raja M wrote:
>>>> On Mon, Feb 12, 2024 at 10:36 PM Andrew Davis via
>>>> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org&c=E,1,2DS7l4Ll0Z71XJHz-8l2SWUjg27KV1rvg3XF0AMYsnwQk1_ugC9LSBcJkDKPbky1ukBO3cDGKWYMyz4aGetIoLWygeMbGXIVsFLmFXec-9wrwA,,&typo=1 <afd=ti.com@lists.yoctoproject.org> wrote:
>>>>>
>>>>> On 2/12/24 10:31 AM, Sinthu Raja M via https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org&c=E,1,kscN3qPdyfL8tn7Fw-OJJ9CSmKtK9jbcAAMJp2zK3KmVWYUG53IuOFVHam_hakwWdc6Wz-dhlHPCRsgWyFh-wNcu5rYmRVFvsvOAzklEyTdmmp7vwy5aHK4QNX0,&typo=1 wrote:
>>>>>> From: Sinthu Raja <sinthu.raja@ti.com>
>>>>>>
>>>>>> AM57x platform supports OMAP DRM. By default the pykms library
>>>>>> disabled the OmapCard support. Enable the same by defining the
>>>>>> HAS_LIBDRM_OMAP as a compiler flags
>>>>>
>>>>> What project uses this feature? I didn't think there were any
>>>>> remaining users of the libdrm OMAP specific framebuffers.
>>>>>
>>>> I am not sure about the users of the libdrm, As mentioned AM57x SDK
>>>> uses OMAP DRM and all the DSS test cases from LTP that use the PYKMS
>>>> library are failing due to the OmapCard property being unavailable.
>>>> Devarsh/Udit,
>>>> Please help in understanding the project that uses this feature.
>>
>> The only reason to use OmapCard and OmapFramebuffer is to use the TILER.
>> If none of the users need TILER, there's no reason to enable the OMAP
>> support. But no harm either.
>>
>> That said, kms++ automatically builds in the omap support if the
>> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flibdrm_omap.so&c=E,1,F-fI2ZgbaQwMkyR6160HbqwP2KIOJTL1ocsF1DbtMr1q-ikrrR7qt-6RBMAiodzw_sRQMFEoBWSLDqy1FRCACt9HWnTxKqq0f8ylrjtF-_o-kw,,&typo=1 is found, and it also enables the OMAP support for the
>> python bindings. So it should "just work". However, the kms++ meson
>> files had a bug and the OMAP support for py bindings was not enabled
>> correctly. This has been fixed quite a while ago in upstream kms++.
>>
>> Looking at the patch, if I read it right, it doesn't look correct as it
>> unconditionally enables HAS_LIBDRM_OMAP. HAS_LIBDRM_OMAP should only be
>> set if the libdrm_omap is available.
>>
>>    Tomi
> 
> Thanks, Tomi.
> 
> Denys/Andrew,
> As Tomi mentioned the fix is available in the below commit of  [1].
> 2236a8ccacdfed5ff5f6873ed6618eccf570193d. Please suggest in that case
> if is it fine to change the SRCREV of this recipe or just backport the
> patch.

If there is a fix upstream then bump the SRCREV to the latest.

> 
> [1]:  https://github.com/tomba/kmsxx
> 
> Sinthu Raja.
>>
>>>>> Andrew
>>>
>>> I am not sure I got the question but to elaborate libdrm is a basic component
>>> required and enabled for all TI platforms involving display as it provides
>>> test utilities and drm/kms helper libs.

I was asking specifically about the OmapCard feature, not libdrm itself.
Do any of our demos or tests still use that, if so we should fix that,
OmapCard/OmapFramebuffer should be deprecated out.

Thanks,
Andrew

>>> I think there are multiple package-groups referring this package along with
>>> some other packages viz gstreamer.
>>>
>>> Coming back to kms++, this too is being used for all TI platforms involving
>>> display, it is referring to https://github.com/tomba/kmsxx and as Sinthu
>>> mentioned it is being used internally for ltp-ddt based tests and externally
>>> for SDK they provide some test utilities viz. kmstest which are already being
>>> referred in SDK [1]
>>>
>>>>>
>>>>>> The patch looks, ok to me as it only enables/impacts AM57x.
>>>
>>>>>> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>>
>>> Reviewed-by" Devarsh Thakkar <devarsht@ti.com>
>>>
>>> [1] :
>>> https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/09_01_00_08/exports/docs/linux/Foundational_Components/Kernel/Kernel_Drivers/Display/DSS7.html?highlight=kmstest
>>>
>>> Regards
>>> Devarsh
>>>>>> ---
>>>>>>     ...-Add-OMAP-Card-support-for-AM57x-DRM.patch | 26 +++++++++++++++++++
>>>>>>     .../recipes-graphics/kms++/kms++https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f_git.bb&c=E,1,Vzf5PFTG5SYCJ06T3yo-D9goAOsCzXx6j38cESyqUKm6bW2m0vjadcXFO4tYk7Z4AoCEzcxMcfH2yWcmR7AGAI3iS8908081V99Qp3OI&typo=1       |  2 ++
>>>>>>     2 files changed, 28 insertions(+)
>>>>>>     create mode 100644 meta-arago-extras/recipes-graphics/kms++/kms++/0001-Add-OMAP-Card-support-for-AM57x-DRM.patch
>>>>>>
>>>>>> diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++/0001-Add-OMAP-Card-support-for-AM57x-DRM.patch b/meta-arago-extras/recipes-graphics/kms++/kms++/0001-Add-OMAP-Card-support-for-AM57x-DRM.patch
>>>>>> new file mode 100644
>>>>>> index 00000000..48c9068d
>>>>>> --- /dev/null
>>>>>> +++ b/meta-arago-extras/recipes-graphics/kms++/kms++/0001-Add-OMAP-Card-support-for-AM57x-DRM.patch
>>>>>> @@ -0,0 +1,26 @@
>>>>>> +From bc6e89ea8695c7e94eb6892755e47781682e28a7 Mon Sep 17 00:00:00 2001
>>>>>> +From: Sinthu Raja <sinthu.raja@ti.com>
>>>>>> +Date: Mon, 12 Feb 2024 21:47:52 +0530
>>>>>> +Subject: [PATCH] Add OMAP Card support for AM57x DRM
>>>>>> +
>>>>>> +Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>>>>>> +---
>>>>>> + py/pykms/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,3VCAN204TlXYB924QYhLMMEmS93WM1kI_7WmS3ER9jLN5pLix8cagolTrEvejlCBBH-6kJs1N3t2LVtFoPbZ4xidt6HUBa1uunFPxUjOug,,&typo=1 | 2 +-
>>>>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>> +
>>>>>> +diff --git a/py/pykms/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,o8lmqQiC6J9IgNrnPW02TiqhU9slv8AROCpl-FW_llYTMZRIt7B9DNgXlwyTsVRybqt9JrdnUp4lFj2mnvG1JorIq2frQLUKKiSQMRkVSQ,,&typo=1 b/py/pykms/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,7abaHpO_lRHPBP8JIr9MMmwEJgbhJGQvzEk94uebIZ78HMKGvnPd6AJXiQWn3o9mvRW19xJfgDPCCtq6B8meJ2GtWsdRyTyaY91OqtPxm_kCY0fu&typo=1
>>>>>> +index de05d12..ce6c013 100644
>>>>>> +--- a/py/pykms/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,CTfRZi_8_1fCYZFyzQLhaCWcgOvqcoQSrttD13hjpdCtg7LH0rbApgfkSXMafnXyhTGtYbRdKqEDzSyZdI6MR-TAodV5cz3gE0IVAe_48k4,&typo=1
>>>>>> ++++ b/py/pykms/https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fmeson.build&c=E,1,ap4x9zvJd5ZfQQuzZtnoEYjDrKN8fm30VUvYKc4WBVkCj_QiawTvIR955h0RVe68z90BAoT47PzbUKGf-lahu3TSAco_s1ek0G5jY6j5KVUxOF9fxIXAdw,,&typo=1
>>>>>> +@@ -49,7 +49,7 @@ if get_option('libutils')
>>>>>> +     pykms_deps += [ libkmsxxutil_dep ]
>>>>>> + endif
>>>>>> +
>>>>>> +-pykms_args = [ '-fvisibility=hidden' ]
>>>>>> ++pykms_args = [ '-fvisibility=hidden' , '-DHAS_LIBDRM_OMAP' ]
>>>>>> +
>>>>>> + destdir = get_option('libdir') / 'python' + py3_dep.version() / 'site-packages/pykms'
>>>>>> +
>>>>>> +--
>>>>>> +2.36.1
>>>>>> +
>>>>>> diff --git a/meta-arago-extras/recipes-graphics/kms++/kms++https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f_git.bb&c=E,1,kFBJhILkClnWLQZ1VsDVvzHIYdIol8wO3afczk4Uen3PzHc7X2U3cFd80w0DSM49pPdFlDU1Dh9UqRonCd0KwAF9PRrOlUGk2T9QBEpNdkvMcV2HHHoauGuo&typo=1 b/meta-arago-extras/recipes-graphics/kms++/kms++https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f_git.bb&c=E,1,kPor2mDuLLEo3MFONlyaNkM5rbbv6jkGQwmvO4IObk5bECLVJ0_YL9LvEe9tr9h6BuBgSYfYwGvRguwCdZ4UYFwMr0tGWXeGYUGzjohMtLQQ7Jbk&typo=1
>>>>>> index 2c0abaa7..010a1f0a 100644
>>>>>> --- a/meta-arago-extras/recipes-graphics/kms++/kms++https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f_git.bb&c=E,1,mK1lB4bE0aDJdjlv1Dc855v3V2yeoxk-ddZjn4hISG1jQ5RjqUCrJVFni5oTDgDY2hpB_L3vmOnB8HNgySj_Zm9H4RBaPurZv74MrbJVEDVgJrQ9ZRHYQvtR-fE,&typo=1
>>>>>> +++ b/meta-arago-extras/recipes-graphics/kms++/kms++https://linkprotect.cudasvc.com/url?a=https%3a%2f%2f_git.bb&c=E,1,Edi_h690Q45x6mNZKj7Hq8nO-rj_27k6LCB1QwLmJcs-f2MrjyyZVMPUAoOftvQrGsG6noSFYTuJ_lKzyZ1rVw1oOfqOPvRP3sJAIW5uSzCZCdiX4g,,&typo=1
>>>>>> @@ -28,3 +28,5 @@ inherit python3native meson pkgconfig update-alternatives
>>>>>>     ALTERNATIVE_PRIORITY = "100"
>>>>>>     ALTERNATIVE:${PN} = "kmstest"
>>>>>>     ALTERNATIVE_LINK_NAME[kmstest] = "${bindir}/kmstest"
>>>>>> +
>>>>>> +SRC_URI:append:am57xx = "file://0001-Add-OMAP-Card-support-for-AM57x-DRM.patch"
>>>>>
>>>>>
>>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>>> Links: You receive all messages sent to this group.
>>>>> View/Reply Online (#15167): https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org%2fg%2fmeta-arago%2fmessage%2f15167&c=E,1,JtVExiEgzitnnI9qeraGw9E_SzOz72-2Q2QM8GZFdv0pOYZMu3uO-r7hBg82htXSocj3VT8POE6u5-g4AVaWL5GwtLF-iHfIODgin99aYA,,&typo=1
>>>>> Mute This Topic: https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org%2fmt%2f104314617%2f6034914&c=E,1,-WBOvjwcnZv0seovJR_eJVo3cUVK4g8QVlqMZb4F0nk2HYj9rqWNk965AyXgwUCTXOp0JTjb1-1S4nNv6Hh9HrRoCt-KW5KQL7-c_V7zed4uT9nvwQmgrMs6s-I,&typo=1
>>>>> Group Owner: meta-arago+owner@lists.yoctoproject.org
>>>>> Unsubscribe: https://linkprotect.cudasvc.com/url?a=https%3a%2f%2flists.yoctoproject.org%2fg%2fmeta-arago%2funsub&c=E,1,feMuc5YJja6GtaJWPLw0gp3grSLOOzxqhyzvpUa2rttsNG0zGo1TX2Z3LSqkSj_zI91F2aRQZ0Rbx_MrEnWld-9WP_qHdL6bC8aDsj1jUo7txAauSwnZsqCdyg,,&typo=1 [sinthu.raja@mistralsolutions.com]
>>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> With Regards
>>>> Sinthu Raja
>>
> 
>