* [meta-arago][oe-layersetup PATCH] Fix non-standard shell usage
@ 2022-04-26 20:05 Andrew Davis
2022-04-26 21:04 ` Denys Dmytriyenko
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Davis @ 2022-04-26 20:05 UTC (permalink / raw)
To: Denys Dmytriyenko, Ryan Eatmon, Nishanth Menon, meta-arago; +Cc: Andrew Davis
Remove some Bashisms that prevent prevent this script from working
on stock Ubuntu (with Dash default interpreter).
Signed-off-by: Andrew Davis <afd@ti.com>
---
oe-layertool-setup.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh
index f171f94..e05737b 100755
--- a/oe-layertool-setup.sh
+++ b/oe-layertool-setup.sh
@@ -780,7 +780,7 @@ print_image_names() {
for FOLDER in ${FOLDERS}
do
RECO=""
- if [ "${FOLDER}" == "meta-arago" ]; then
+ if [ "${FOLDER}" = "meta-arago" ]; then
RECO="[recommended]"
fi
echo "From ${FOLDER}${RECO}:"
@@ -796,7 +796,7 @@ print_image_names() {
if [ -z "${summary}" ]; then
summary="No Summary available"
fi
- echo -e "\t${name}: ${summary}"
+ echo " ${name}: ${summary}"
done
fi
done
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-arago][oe-layersetup PATCH] Fix non-standard shell usage
2022-04-26 20:05 [meta-arago][oe-layersetup PATCH] Fix non-standard shell usage Andrew Davis
@ 2022-04-26 21:04 ` Denys Dmytriyenko
2022-04-26 21:38 ` Ryan Eatmon
0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2022-04-26 21:04 UTC (permalink / raw)
To: afd; +Cc: Ryan Eatmon, Nishanth Menon, meta-arago
On Tue, Apr 26, 2022 at 03:05:29PM -0500, Andrew F. Davis via lists.yoctoproject.org wrote:
> Remove some Bashisms that prevent prevent this script from working
> on stock Ubuntu (with Dash default interpreter).
>
> Signed-off-by: Andrew Davis <afd@ti.com>
Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
> oe-layertool-setup.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh
> index f171f94..e05737b 100755
> --- a/oe-layertool-setup.sh
> +++ b/oe-layertool-setup.sh
> @@ -780,7 +780,7 @@ print_image_names() {
> for FOLDER in ${FOLDERS}
> do
> RECO=""
> - if [ "${FOLDER}" == "meta-arago" ]; then
> + if [ "${FOLDER}" = "meta-arago" ]; then
> RECO="[recommended]"
> fi
> echo "From ${FOLDER}${RECO}:"
> @@ -796,7 +796,7 @@ print_image_names() {
> if [ -z "${summary}" ]; then
> summary="No Summary available"
> fi
> - echo -e "\t${name}: ${summary}"
> + echo " ${name}: ${summary}"
> done
> fi
> done
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-arago][oe-layersetup PATCH] Fix non-standard shell usage
2022-04-26 21:04 ` Denys Dmytriyenko
@ 2022-04-26 21:38 ` Ryan Eatmon
0 siblings, 0 replies; 3+ messages in thread
From: Ryan Eatmon @ 2022-04-26 21:38 UTC (permalink / raw)
To: Denys Dmytriyenko, afd; +Cc: Nishanth Menon, meta-arago
Patch applied to master.
On 4/26/2022 16:04, Denys Dmytriyenko wrote:
> On Tue, Apr 26, 2022 at 03:05:29PM -0500, Andrew F. Davis via lists.yoctoproject.org wrote:
>> Remove some Bashisms that prevent prevent this script from working
>> on stock Ubuntu (with Dash default interpreter).
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>
> Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>
>
>
>> ---
>> oe-layertool-setup.sh | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/oe-layertool-setup.sh b/oe-layertool-setup.sh
>> index f171f94..e05737b 100755
>> --- a/oe-layertool-setup.sh
>> +++ b/oe-layertool-setup.sh
>> @@ -780,7 +780,7 @@ print_image_names() {
>> for FOLDER in ${FOLDERS}
>> do
>> RECO=""
>> - if [ "${FOLDER}" == "meta-arago" ]; then
>> + if [ "${FOLDER}" = "meta-arago" ]; then
>> RECO="[recommended]"
>> fi
>> echo "From ${FOLDER}${RECO}:"
>> @@ -796,7 +796,7 @@ print_image_names() {
>> if [ -z "${summary}" ]; then
>> summary="No Summary available"
>> fi
>> - echo -e "\t${name}: ${summary}"
>> + echo " ${name}: ${summary}"
>> done
>> fi
>> done
>> --
>> 2.17.1
--
Ryan Eatmon reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc. - LCPD - MGTS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-26 21:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 20:05 [meta-arago][oe-layersetup PATCH] Fix non-standard shell usage Andrew Davis
2022-04-26 21:04 ` Denys Dmytriyenko
2022-04-26 21:38 ` Ryan Eatmon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).