meta-arm.lists.yoctoproject.org archive mirror
 help / color / mirror / Atom feed
From: Ross Burton <ross.burton@arm.com>
To: meta-arm@lists.yoctoproject.org
Subject: [PATCH 3/7] arm/fvpboot: clean up fvpboot_vars
Date: Mon, 27 Sep 2021 13:55:58 +0100	[thread overview]
Message-ID: <20210927125602.3400822-3-ross.burton@arm.com> (raw)
In-Reply-To: <20210927125602.3400822-1-ross.burton@arm.com>

Change-Id: I43a04cd1b977fbf7d0050b2ab9e7509c0439dca5
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-arm/classes/fvpboot.bbclass | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/meta-arm/classes/fvpboot.bbclass b/meta-arm/classes/fvpboot.bbclass
index 18a9d686..de66d7ce 100644
--- a/meta-arm/classes/fvpboot.bbclass
+++ b/meta-arm/classes/fvpboot.bbclass
@@ -74,7 +74,8 @@ python do_write_fvpboot_conf() {
 }
 
 def fvpboot_vars(d):
-    build_vars = ['DEPLOY_DIR_IMAGE', 'IMAGE_NAME', 'IMAGE_LINK_NAME',
-                  'COMPONENTS_DIR', 'BUILD_ARCH']
-    return build_vars + [k for k in d.keys() if k.startswith('FVP_')]
-do_write_fvpboot_conf[vardeps] += "${@' '.join(fvpboot_vars(d))}"
+    vars = ['DEPLOY_DIR_IMAGE', 'IMAGE_NAME', 'IMAGE_LINK_NAME', 'COMPONENTS_DIR', 'BUILD_ARCH']
+    vars.extend((k for k in d.keys() if k.startswith('FVP_')))
+    return " ".join(vars)
+
+do_write_fvpboot_conf[vardeps] += "${@fvpboot_vars(d)}"
-- 
2.25.1



  parent reply	other threads:[~2021-09-27 12:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 12:55 [PATCH 1/7] arm-bsp/fvp-base: tell FVP to exit on shutdown Ross Burton
2021-09-27 12:55 ` [PATCH 2/7] arm-bsp/fvp-base: enable user-mode networking in runfvp Ross Burton
2021-09-27 12:55 ` Ross Burton [this message]
2021-09-27 12:55 ` [PATCH 4/7] runfvp: handle control-c cleanly Ross Burton
2021-09-27 12:56 ` [PATCH 5/7] runfvp: refactor argument parsing Ross Burton
2021-09-27 12:56 ` [PATCH 6/7] runfvp: ensure the default terminal is usable Ross Burton
2021-09-27 12:56 ` [PATCH 7/7] runfvp: exit cleanly if tinfoil cannot be imported Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927125602.3400822-3-ross.burton@arm.com \
    --to=ross.burton@arm.com \
    --cc=meta-arm@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).