* [PATCH] meta-arm-toolchain: Convert to new override syntax
@ 2021-08-02 16:35 Khem Raj
2021-08-03 5:25 ` [meta-arm] " Sumit Garg
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2021-08-02 16:35 UTC (permalink / raw)
To: meta-arm; +Cc: Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta-arm-toolchain/conf/layer.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
index 04486d4..41305ee 100644
--- a/meta-arm-toolchain/conf/layer.conf
+++ b/meta-arm-toolchain/conf/layer.conf
@@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
BB_DANGLINGAPPENDS_WARNONLY = "true"
# These variables are used for armcompiler license
-BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
+BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [meta-arm] [PATCH] meta-arm-toolchain: Convert to new override syntax
2021-08-02 16:35 [PATCH] meta-arm-toolchain: Convert to new override syntax Khem Raj
@ 2021-08-03 5:25 ` Sumit Garg
2021-08-03 5:49 ` Khem Raj
0 siblings, 1 reply; 3+ messages in thread
From: Sumit Garg @ 2021-08-03 5:25 UTC (permalink / raw)
To: Khem Raj; +Cc: meta-arm
Hi Khem,
On Mon, 2 Aug 2021 at 22:05, Khem Raj <raj.khem@gmail.com> wrote:
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta-arm-toolchain/conf/layer.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
> index 04486d4..41305ee 100644
> --- a/meta-arm-toolchain/conf/layer.conf
> +++ b/meta-arm-toolchain/conf/layer.conf
> @@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
> BB_DANGLINGAPPENDS_WARNONLY = "true"
>
> # These variables are used for armcompiler license
> -BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
> +BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
This only looks like change for one instance of override and there are
many other instances in meta-arm-toolchain. I think the new override
syntax brings more clarity. So I would suggest converting all other
instances of overrides to new syntax as well.
-Sumit
> --
> 2.32.0
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [meta-arm] [PATCH] meta-arm-toolchain: Convert to new override syntax
2021-08-03 5:25 ` [meta-arm] " Sumit Garg
@ 2021-08-03 5:49 ` Khem Raj
0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2021-08-03 5:49 UTC (permalink / raw)
To: Sumit Garg; +Cc: meta-arm
yeah ignore this. I have more changes after this
On Mon, Aug 2, 2021 at 10:25 PM Sumit Garg <sumit.garg@linaro.org> wrote:
>
> Hi Khem,
>
> On Mon, 2 Aug 2021 at 22:05, Khem Raj <raj.khem@gmail.com> wrote:
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > ---
> > meta-arm-toolchain/conf/layer.conf | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta-arm-toolchain/conf/layer.conf b/meta-arm-toolchain/conf/layer.conf
> > index 04486d4..41305ee 100644
> > --- a/meta-arm-toolchain/conf/layer.conf
> > +++ b/meta-arm-toolchain/conf/layer.conf
> > @@ -18,4 +18,4 @@ LAYERSERIES_COMPAT_arm-toolchain = "hardknott"
> > BB_DANGLINGAPPENDS_WARNONLY = "true"
> >
> > # These variables are used for armcompiler license
> > -BB_HASHBASE_WHITELIST_append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
> > +BB_HASHBASE_WHITELIST:append = " ARM_TOOL_VARIANT ARMLMD_LICENSE_FILE LM_LICENSE_FILE"
>
> This only looks like change for one instance of override and there are
> many other instances in meta-arm-toolchain. I think the new override
> syntax brings more clarity. So I would suggest converting all other
> instances of overrides to new syntax as well.
>
> -Sumit
>
> > --
> > 2.32.0
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-03 5:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 16:35 [PATCH] meta-arm-toolchain: Convert to new override syntax Khem Raj
2021-08-03 5:25 ` [meta-arm] " Sumit Garg
2021-08-03 5:49 ` Khem Raj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).